From owner-freebsd-current@FreeBSD.ORG Mon Oct 8 15:31:12 2007 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 524E016A468; Mon, 8 Oct 2007 15:31:12 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from gnome.kiev.sovam.com (gnome.kiev.sovam.com [212.109.32.24]) by mx1.freebsd.org (Postfix) with ESMTP id E7DD213C4A5; Mon, 8 Oct 2007 15:31:11 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay02.kiev.sovam.com ([62.64.120.197]) by gnome.kiev.sovam.com with esmtp (Exim 4.67 (FreeBSD)) (envelope-from ) id 1IeuZb-000EWA-0H; Mon, 08 Oct 2007 18:31:11 +0300 Received: from [212.82.216.226] (helo=deviant.kiev.zoral.com.ua) by relay02.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1IeuZX-000JkX-Hq; Mon, 08 Oct 2007 18:31:10 +0300 Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1) with ESMTP id l98FV7SV035915; Mon, 8 Oct 2007 18:31:07 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1/Submit) id l98FV6c4035910; Mon, 8 Oct 2007 18:31:06 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 8 Oct 2007 18:31:06 +0300 From: Kostik Belousov To: Roman Divacky Message-ID: <20071008153106.GN2180@deviant.kiev.zoral.com.ua> References: <20071007140237.GA44735@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Kynn+LdAwU9N+JqL" Content-Disposition: inline In-Reply-To: <20071007140237.GA44735@freebsd.org> User-Agent: Mutt/1.4.2.3i X-Scanner-Signature: fa1e9f04260dd27375e84b1224048298 X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Info: Profiles 1570 [Oct 08 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {received from trusted relay: not dialup} X-SpamTest-Method: none X-SpamTest-Method: Local Lists X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release Cc: current@freebsd.org, peter@freebsd.org Subject: Re: pad argument for mmap/lseek/etc. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2007 15:31:12 -0000 --Kynn+LdAwU9N+JqL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 07, 2007 at 04:02:37PM +0200, Roman Divacky wrote: > hi >=20 > 3 months ago Peter Wemm removed "pad" argument from mmap/lseek/etc. sysca= lls > arguments. >=20 > Unfortunately he forgot to update the struct XYZ_args definitions shipped > with the actual functions like this: >=20 > vm/vm_mmap.c: >=20 > #ifndef _SYS_SYSPROTO_H_ > struct mmap_args { > void *addr; > size_t len; > int prot; > int flags; > int fd; > long pad; > off_t pos; > }; > #endif >=20 > /* > * MPSAFE > */ > int > mmap(td, uap) > struct thread *td; > struct mmap_args *uap; >=20 > it would be nice to get this removed. I'd submit a patch but I dont > know what syscalls this affected. You should lookup the corresponding commit that obviously touched syscalls.master (seems to be rev. 1.232), and get the syscalls list from there. Then, you should copy the old structure definitions to freebsd6_XXX functions, and delete the paddings inplace. The interesting question is whether the _SYS_SYSPROTO_H and absense of the sys/sysproto.h supported. Or, shall we remove these #ifdef blocks instead of fixing them in whole kernel. --Kynn+LdAwU9N+JqL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHCk06C3+MBN1Mb4gRApzUAKDIZVtxRXcKRMj+TuKihD6Y5PJwzwCdGcKT kwYDwtOw4ECnizLy9/JzIAk= =LwWF -----END PGP SIGNATURE----- --Kynn+LdAwU9N+JqL--