From owner-svn-src-all@FreeBSD.ORG Tue Jul 28 17:35:08 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 19EEB106566B; Tue, 28 Jul 2009 17:35:08 +0000 (UTC) (envelope-from Tor.Egge@cvsup.no.freebsd.org) Received: from pil.idi.ntnu.no (pil.idi.ntnu.no [129.241.107.93]) by mx1.freebsd.org (Postfix) with ESMTP id 90B1B8FC19; Tue, 28 Jul 2009 17:35:07 +0000 (UTC) (envelope-from Tor.Egge@cvsup.no.freebsd.org) Received: from cvsup.no.freebsd.org (c2h5oh.idi.ntnu.no [129.241.103.69]) by pil.idi.ntnu.no (8.14.1/8.13.1) with ESMTP id n6SHAQmJ016372 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 28 Jul 2009 19:10:27 +0200 (MEST) Received: from localhost (localhost [127.0.0.1]) by cvsup.no.freebsd.org (8.14.2/8.14.2) with ESMTP id n6SHAQm1048803; Tue, 28 Jul 2009 17:10:26 GMT (envelope-from Tor.Egge@cvsup.no.freebsd.org) Date: Tue, 28 Jul 2009 17:09:55 +0000 (UTC) Message-Id: <20090728.170954.74706437.Tor.Egge@cvsup.no.freebsd.org> To: julian@freebsd.org From: Tor Egge In-Reply-To: <200907250642.n6P6ggKw032784@svn.freebsd.org> References: <200907250642.n6P6ggKw032784@svn.freebsd.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Virus-Scanned-By: mimedefang.idi.ntnu.no, using CLAMD X-SMTP-From: Sender=, Relay/Client=c2h5oh.idi.ntnu.no [129.241.103.69], EHLO=cvsup.no.freebsd.org X-Scanned-By: MIMEDefang 2.48 on 129.241.107.38 X-Scanned-By: mimedefang.idi.ntnu.no, using MIMEDefang 2.48 with local filter 16.42-idi X-Filter-Time: 1 seconds Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r195862 - head/sys/netinet/ipfw X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2009 17:35:09 -0000 This commit causes my laptop to hang during boot. ipfw and ipfw_nat are both compiled into the kernel: options IPFIREWALL options IPFIREWALL_VERBOSE options IPFIREWALL_VERBOSE_LIMIT=100 options IPFIREWALL_FORWARD options IPFIREWALL_NAT options IPDIVERT The kernel hangs during IPFW_WLOCK(&V_layer3_chain); at the start of ipfw_nat_init. The lock is not yet initialized at this time (SI_SUB_PROTO_IFATTACHDOMAIN, SI_ORDER_ANY), since the commit moved the initialization of the lock from (SI_SUB_PROTO_IFATTACHDOMAIN, SI_ORDER_ANY - 256) (cf. ipfw_modevent() calling ipfw_init()) to (SI_SUB_KTHREAD_INIT, SI_ORDER_ANY) (cf. vnet_ipfw_init()). - Tor Egge