From nobody Mon Jul 28 13:31:17 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4brKBG1ZXLz634sR; Mon, 28 Jul 2025 13:31:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4brKBF1CN6z3tdZ; Mon, 28 Jul 2025 13:31:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753709477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2H+EuLVnwdNlNi5xx0CksPZDce1DIyD1UGj8i16Ru2E=; b=uFSEHQRv0ZYkWpfofwzPvg7CpYGj/DXpHQAHGjc1v5aGGrhLEtuXEUzrYJAjWHC4IdCh9k N5Pz0J342KR97eBo21lnK2BLQb9EeW/7mQ72aQHA44ox+ZOxYwJvBOvmyR8y94UoOn9iNf IXnF9TE+w4HHFx1mULwWo89AQaQByX0VUG0czl5c0fdX1Li/DN/uWItoxv6IlxKu6wI9x0 M1JEg9Np3ZUFtajNCPy8RJ5zAzVi2+I5IUQM/YYHqSaHvXQob0vBW7VKEN7C+0y7KO0XLv LLi6mFh214pQPyc7BMbgwfneUMmtPhhwuFcUwDq+GtlV8MH6SICURY9/EJqt+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753709477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2H+EuLVnwdNlNi5xx0CksPZDce1DIyD1UGj8i16Ru2E=; b=Lawk7gYAMQs2BiVODbJpNrWN8SsaTV2E/lZO9ZnmKey1pMuhIQ8wvJ7Q+ON7znskOtyp5w Zu6e+7fVDi3JNNgXYcbKCzWOXcJanbEtgfWztB3xGL2xzXSTxI0CqMcsECnJ1PjhvvJgTr CJN06JmhrVmIApltvc0vZ4C/VXJ4+mPR/bFZL9RDZ2UJUYY6FA4ZypB6n7/4WUzDlpYckb YRGVKQyuAb3oZEIksRDi8cO/1dlRBHQ1CAKi5V79cxTU6XaOI97cokXizX5VnaQWyHbwFY nnpfteLvENdIrdgQGQ16F5udSWOWnh5KJ6FVcVAdPYX7G4eV/68EJriK/Pa/Rg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753709477; a=rsa-sha256; cv=none; b=CPsDjFfhsCtJLUbtK/uyOBeX+AltBtkj3TNWRrAoVhHCHqzssfBhpaCfW2JlTQ3RhWnrMK 52gDkxG8hFO4DMxJt8uYM26Ij4f2QXN6VsflU8Pz85+iqP1U87Lx48JC32Yg20AQQnr/FK vMgrb4ZgZNThUf1z6qlb3+ZMlidI58Oyh9oq78SpJS4t8v7cxf2a3bhHqrmFTohBoKazQw ARzgoZkwCWrKjSI27iGFShtodN6QdNbtvhrK0PL0+s4LcgcKufFQn/m5TBJnIzOKkG0/EI wu+S5GlB2rH6YZp9O5IzEHktBWL+d6bBb5BeicJ7cOyrjvPFXlCVMZbioHSc8w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4brKBF0g1ZznCK; Mon, 28 Jul 2025 13:31:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56SDVHm8080163; Mon, 28 Jul 2025 13:31:17 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56SDVH3U080159; Mon, 28 Jul 2025 13:31:17 GMT (envelope-from git) Date: Mon, 28 Jul 2025 13:31:17 GMT Message-Id: <202507281331.56SDVH3U080159@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: bfd59136bece - stable/14 - runq: runq_check(): Re-implement on top of runq_findq() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: bfd59136bece048f2c4646d6e7a1ba48a3ce7a36 Auto-Submitted: auto-generated The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=bfd59136bece048f2c4646d6e7a1ba48a3ce7a36 commit bfd59136bece048f2c4646d6e7a1ba48a3ce7a36 Author: Olivier Certner AuthorDate: 2024-02-29 18:10:58 +0000 Commit: Olivier Certner CommitDate: 2025-07-28 13:28:10 +0000 runq: runq_check(): Re-implement on top of runq_findq() Remove one more loop and duplicated code, with the benefit of less instruction cache pollution at the expense of a few cycles more for the function calls and computing 'idx' (however, this gives a better diagnostic message). Reviewed by: kib MFC after: 1 month Event: Kitchener-Waterloo Hackathon 202506 Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D45387 (cherry picked from commit de78657a3aef3c2efbcbdf9ea73a95283c91fab0) --- sys/kern/kern_switch.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/sys/kern/kern_switch.c b/sys/kern/kern_switch.c index a321aecc55fb..59925c10c30d 100644 --- a/sys/kern/kern_switch.c +++ b/sys/kern/kern_switch.c @@ -445,17 +445,15 @@ runq_findq(struct runq *const rq) bool runq_not_empty(struct runq *rq) { - struct rq_status *rqs; + int idx; - rqs = &rq->rq_status; - for (int i = 0; i < RQSW_NB; i++) - if (rqs->rq_sw[i] != 0) { - CTR2(KTR_RUNQ, "runq_not_empty: bits=%#x i=%d", - rqs->rq_sw[i], i); - return (true); - } - CTR0(KTR_RUNQ, "runq_not_empty: empty"); + idx = runq_findq(rq); + if (idx != -1) { + CTR1(KTR_RUNQ, "runq_not_empty: idx=%d", idx); + return (true); + } + CTR0(KTR_RUNQ, "runq_not_empty: empty"); return (false); }