From nobody Sun Aug 28 10:31:24 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MFqcc0S4jz4bJJf for ; Sun, 28 Aug 2022 10:31:44 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MFqcb1DdBz3yLf for ; Sun, 28 Aug 2022 10:31:43 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-ed1-x52a.google.com with SMTP id a36so3190260edf.5 for ; Sun, 28 Aug 2022 03:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=aOjE/swPJmLCbYUHT8qoqQ2ulYaDy7WJMFeimng1s+c=; b=vsOdcQgPDNRM6QROCWnp10rXm0YgFA/58fQwhos0zn4IyUgjteijIiBiP2nPypG5t/ bgL/52LnA89S2s6ziF2AF92mKA+Hw8BUluZJ9s3VmSDyN6MPaMNEyraWQGffO5qGwGIF 5LR4+Y7OB1G6ixMHVtuZltSN0EAnbAj1mEb64yj0yR299DkfKnmo3y56MIi7ru79FJ9J 4puXhkiOturIJNOU/2L3S/4sRQ0p7wvQj6u4O0zOJXfSUOzEttekSKlCVrTX7BGmyKoQ nV46duBY7ClXKDoid+V2ryTik2rPi5XbT+z3R3tRHrzY3pPTBEULvS/FnERr+ayN0mhA iRuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=aOjE/swPJmLCbYUHT8qoqQ2ulYaDy7WJMFeimng1s+c=; b=N8v3OFBopDTnRWCRtEZio9phuzHYG6sASUHvLodp7142xETKT1gJ8m0HYGbwjDoDGw p11Kl/hfthQ4EiR3nsHIY2yFE/C4DohLZD9L8Ce3eHi4Ft8w8B3uXiI/B0u7L2x5nhJX /z3AtvF9/PB0wZ9tA62RAynqL7PJFheBCg4ABKnCH57ZSuLMJvoJc6xNHU8bFiXrpLDq w8vQZqSieuhii2ldaBNwycLGv7lzvAafc/+rK+ST2IqW7OkFwnwX8u1aAOuJCpNrYpDO sCa1PcjPBmRyfsiUd6+YxwMMlPMoRhAApBwmQeEQ7bnjpyIZWriLnVGzvzo1u4iYJxcp YwHQ== X-Gm-Message-State: ACgBeo0YCq9/3oRyRZGXptD9WHAtqsGhYh7r9RyAnJKw/nDA9kIrpWoW 3KEXCHZbzQ5ya8J9wNBi5K22TCeFRKWAXTZETzfAJQ== X-Google-Smtp-Source: AA6agR5E8f1XBUN5wMjwVgtlzoz0C8GHSD07hCJbYbOF9rvMY8QYLjEhESuksq3R0SNnBgoIpjdxqcfy0YiGRszQ7TM= X-Received: by 2002:aa7:c585:0:b0:448:24ee:b202 with SMTP id g5-20020aa7c585000000b0044824eeb202mr4500176edq.167.1661682700644; Sun, 28 Aug 2022 03:31:40 -0700 (PDT) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202208271031.27RAV5RN047637@gitrepo.freebsd.org> In-Reply-To: <202208271031.27RAV5RN047637@gitrepo.freebsd.org> From: Adam Weinberger Date: Sun, 28 Aug 2022 04:31:24 -0600 Message-ID: Subject: Re: git: 538a001f90bb - main - archivers/zstd: Change build system from meson to gmake To: Po-Chuan Hsieh Cc: ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000001a08e205e74aa72a" X-Rspamd-Queue-Id: 4MFqcb1DdBz3yLf X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=adamw-org.20210112.gappssmtp.com header.s=20210112 header.b=vsOdcQgP; dmarc=none; spf=pass (mx1.freebsd.org: domain of adamw@adamw.org designates 2a00:1450:4864:20::52a as permitted sender) smtp.mailfrom=adamw@adamw.org X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; R_DKIM_ALLOW(-0.20)[adamw-org.20210112.gappssmtp.com:s=20210112]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::52a:from]; ARC_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[adamw-org.20210112.gappssmtp.com:+]; DMARC_NA(0.00)[adamw.org]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[adamw]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-ports-all@freebsd.org]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N --0000000000001a08e205e74aa72a Content-Type: text/plain; charset="UTF-8" On Sat, Aug 27, 2022 at 4:31 AM Po-Chuan Hsieh wrote: > The branch main has been updated by sunpoet: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=538a001f90bbf14b5bdaa556119925699adb1849 > > commit 538a001f90bbf14b5bdaa556119925699adb1849 > Author: Po-Chuan Hsieh > AuthorDate: 2022-08-27 10:23:30 +0000 > Commit: Po-Chuan Hsieh > CommitDate: 2022-08-27 10:23:30 +0000 > > archivers/zstd: Change build system from meson to gmake > > - Use BINARY_ALIAS and remove TEST_DEPENDS: md5sum from base system > works fine > - Remove TEST option > - Bump PORTREVISION for package change > > from README.md [1]: > make is the officially maintained build system of this project. All > other build > systems are "compatible" and 3rd-party maintained, they may feature > small > differences in advanced options. When your system allows it, prefer > using make > to build zstd and libzstd. > > Reference: > https://github.com/facebook/zstd/blob/dev/README.md#build-instructions [1] > --- > > diff --git a/archivers/zstd/Makefile b/archivers/zstd/Makefile > index 49255dbd1187..ed8af4b8bddf 100644 > --- a/archivers/zstd/Makefile > +++ b/archivers/zstd/Makefile > > +OPTIONS_DEFINE= OPTIMIZED_CFLAGS > > -OPTIONS_DEFINE= LTO LZ4 OPTIMIZED_CFLAGS TEST > -OPTIONS_DEFAULT=LZ4 > - > -LTO_MESON_TRUE= b_lto > -LZ4_LIB_DEPENDS= liblz4.so:archivers/liblz4 > -LZ4_MESON_ENABLED= lz4 > -LZ4_USES= localbase:ldflags > OPTIMIZED_CFLAGS_VARS= CFLAGS+=-O3 > -TEST_MESON_TRUE= bin_tests > Hi Po-Chuan, I did enjoy the speedup from the LTO option. Any interest in adding back an option for -flto? Upstream lib/README.md encourages it for programs that link to zstd, but it's nice to have it for the zstd binary itself too. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org --0000000000001a08e205e74aa72a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


<= div dir=3D"ltr" class=3D"gmail_attr">On Sat, Aug 27, 2022 at 4:31 AM Po-Chu= an Hsieh <sunpoet@freebsd.org= > wrote:
The = branch main has been updated by sunpoet:

URL: https://cgi= t.FreeBSD.org/ports/commit/?id=3D538a001f90bbf14b5bdaa556119925699adb1849

commit 538a001f90bbf14b5bdaa556119925699adb1849
Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2022-08-27 10:23:30 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2022-08-27 10:23:30 +0000

=C2=A0 =C2=A0 archivers/zstd: Change build system from meson to gmake

=C2=A0 =C2=A0 - Use BINARY_ALIAS and remove TEST_DEPENDS: md5sum from base = system works fine
=C2=A0 =C2=A0 - Remove TEST option
=C2=A0 =C2=A0 - Bump PORTREVISION for package change

=C2=A0 =C2=A0 from README.md [1]:
=C2=A0 =C2=A0 make is the officially maintained build system of this projec= t. All other build
=C2=A0 =C2=A0 systems are "compatible" and 3rd-party maintained, = they may feature small
=C2=A0 =C2=A0 differences in advanced options. When your system allows it, = prefer using make
=C2=A0 =C2=A0 to build zstd and libzstd.

=C2=A0 =C2=A0 Reference:=C2=A0 =C2=A0 =C2=A0 https://github.com/facebook/zstd/blob/dev/README.md#build-in= structions [1]
---

diff --git a/archivers/zstd/Makefile b/archivers/zstd/Makefile
index 49255dbd1187..ed8af4b8bddf 100644
--- a/archivers/zstd/Makefile
+++ b/archivers/zstd/Makefile

+OPTIONS_DEFINE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 OPTIMIZED_CFLAGS

-OPTIONS_DEFINE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 LTO LZ4 OPTIMIZED_CFLAGS TEST=
-OPTIONS_DEFAULT=3DLZ4
-
-LTO_MESON_TRUE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 b= _lto
-LZ4_LIB_DEPENDS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0liblz4.so:archivers/liblz4 -LZ4_MESON_ENABLED=3D=C2=A0 =C2=A0 =C2=A0lz4
-LZ4_USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 localbase:ldfl= ags
=C2=A0OPTIMIZED_CFLAGS_VARS=3D CFLAGS+=3D-O3
-TEST_MESON_TRUE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0bin_tests

Hi Po-Chuan,

<= div>
I d= id enjoy the speedup from the LTO option. Any interest in adding back an op= tion for -flto? Upstream lib/README.md encourages it for programs that link= to zstd, but it's nice to have it for the zstd binary itself too.

# A= dam


--
--0000000000001a08e205e74aa72a--