From owner-freebsd-arm@FreeBSD.ORG  Tue May  5 21:19:28 2015
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3111C403
 for <freebsd-arm@freebsd.org>; Tue,  5 May 2015 21:19:28 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 11CA21C6A
 for <freebsd-arm@freebsd.org>; Tue,  5 May 2015 21:19:28 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t45LJRUo062784
 for <freebsd-arm@freebsd.org>; Tue, 5 May 2015 21:19:27 GMT
 (envelope-from daemon-user@phabric-backend.isc.freebsd.org)
Received: (from daemon-user@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t45LJR7O062783;
 Tue, 5 May 2015 21:19:27 GMT (envelope-from daemon-user)
Date: Tue, 5 May 2015 21:19:27 +0000
To: freebsd-arm@freebsd.org
From: "emaste (Ed Maste)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D2377: Introduce ARM GICv3 support
Message-ID: <aae685583e09650f7f056c4b96bce5cc@localhost.localdomain>
X-Priority: 3
Thread-Topic: D2377: Introduce ARM GICv3 support
X-Herald-Rules: <28>, <31>, <32>, <34>, <8>
X-Phabricator-To: <PHID-USER-6m5mo2kjikkzyd33ld4n>
X-Phabricator-To: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-To: <PHID-USER-yhwnadxnjthofqelhkdx>
X-Phabricator-To: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-To: <PHID-USER-pns6zgllnr6ze4h7ms3o>
X-Phabricator-To: <PHID-USER-pkmvihbtt3lba2qkphcz>
X-Phabricator-To: <PHID-USER-cc6daxnrb232k4sqvkvg>
X-Phabricator-To: <PHID-USER-nhm2a2j4zvuftar7szlp>
X-Phabricator-Cc: <PHID-USER-2wocyy2vsyzu2nddvuw6>
X-Phabricator-Cc: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-Cc: <PHID-USER-pns6zgllnr6ze4h7ms3o>
X-Phabricator-Cc: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-Cc: <PHID-MLST-stsrni3uozki6w7zubvy>
In-Reply-To: <differential-rev-PHID-DREV-piql4a7htwxjub743777-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-piql4a7htwxjub743777-req@FreeBSD.org>
Thread-Index: MjA1ZGZkZWI5MTE4ZDk2Nzk0YzAyZGRiMWRiIFVJM98=
Precedence: bulk
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.20
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 May 2015 21:19:28 -0000

emaste added inline comments.

INLINE COMMENTS
  sys/arm64/arm64/gic_v3.c:509 typically for style(9)
  
  I don't see it mentioned in style(9), but I've always been told bitwise comparison of e.g. flags should be == 0 or != 0. This might just be tribal knowledge passed on via mailing lists / code review and should be added to style(9).

REVISION DETAIL
  https://reviews.freebsd.org/D2377

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, emaste, ian, imp, andrew, brueffer, joel, wblock
Cc: kostikbel, emaste, andrew, imp, freebsd-arm