Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 May 2015 21:19:27 +0000
From:      "emaste (Ed Maste)" <phabric-noreply@FreeBSD.org>
To:        freebsd-arm@freebsd.org
Subject:   [Differential] [Commented On] D2377: Introduce ARM GICv3 support
Message-ID:  <aae685583e09650f7f056c4b96bce5cc@localhost.localdomain>
In-Reply-To: <differential-rev-PHID-DREV-piql4a7htwxjub743777-req@FreeBSD.org>
References:  <differential-rev-PHID-DREV-piql4a7htwxjub743777-req@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
emaste added inline comments.

INLINE COMMENTS
  sys/arm64/arm64/gic_v3.c:509 typically for style(9)
  
  I don't see it mentioned in style(9), but I've always been told bitwise comparison of e.g. flags should be == 0 or != 0. This might just be tribal knowledge passed on via mailing lists / code review and should be added to style(9).

REVISION DETAIL
  https://reviews.freebsd.org/D2377

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, emaste, ian, imp, andrew, brueffer, joel, wblock
Cc: kostikbel, emaste, andrew, imp, freebsd-arm



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aae685583e09650f7f056c4b96bce5cc>