From owner-svn-src-all@FreeBSD.ORG Fri Oct 10 15:06:05 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2FCA775A; Fri, 10 Oct 2014 15:06:05 +0000 (UTC) Received: from mail-pa0-x22a.google.com (mail-pa0-x22a.google.com [IPv6:2607:f8b0:400e:c03::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E384F6AF; Fri, 10 Oct 2014 15:06:04 +0000 (UTC) Received: by mail-pa0-f42.google.com with SMTP id bj1so1910882pad.15 for ; Fri, 10 Oct 2014 08:06:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=j2txKVvHw1SoTs4koBIv30dpQ80B9cNpxi5grKLcjhY=; b=mhGfey88lLwsCv8ACPux6xIUdviJ/k8JGcaHTyLlu3KkVZMl3YErU8ubUlDbkiwuAQ gyjiErBNFhpIaJZIdGBQw7zjg+Nf9R6c6oNnYpIN0ua8ljMfP/KW2737504DMSrL55UA 3IyfkttDW2Q77foawtDkKu0ANaXL/YoIzhlzA+rfnV3Duk3V3IolmYYQwb9DiLWgIa9+ 8OGhTF2cLAQkrXQO+LY6m/ZLZ4ZzXRfs6tII11OCIbk1G1QcjevNM+Vb07ycidmtMiAk s7Q4yCg9VLt7o4KZDFUiG0Ydk3UBLlzSXsGuP0GtfXboZEmbDj1IEm64i47e5hn9dPCT 05uA== MIME-Version: 1.0 X-Received: by 10.70.140.199 with SMTP id ri7mr5743303pdb.47.1412953564277; Fri, 10 Oct 2014 08:06:04 -0700 (PDT) Received: by 10.70.9.132 with HTTP; Fri, 10 Oct 2014 08:06:04 -0700 (PDT) In-Reply-To: <20141010145043.GI19486@ivaldir.etoilebsd.net> References: <201410090658.s996wYOr096351@svn.freebsd.org> <1412949811.12052.270.camel@revolution.hippie.lan> <20141010145043.GI19486@ivaldir.etoilebsd.net> Date: Fri, 10 Oct 2014 11:06:04 -0400 Message-ID: Subject: Re: svn commit: r272808 - head/include/rpcsvc From: Benjamin Kaduk To: Baptiste Daroussin Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Ian Lepore X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Oct 2014 15:06:05 -0000 On Fri, Oct 10, 2014 at 10:50 AM, Baptiste Daroussin wrote: > On Fri, Oct 10, 2014 at 08:03:31AM -0600, Ian Lepore wrote: > > On Thu, 2014-10-09 at 06:58 +0000, Baptiste Daroussin wrote: > > > Author: bapt > > > Date: Thu Oct 9 06:58:33 2014 > > > New Revision: 272808 > > > URL: https://svnweb.freebsd.org/changeset/base/272808 > > > > > > -%#define ENTRY_VAL(obj, col) \ > > > - (obj)->EN_data.en_cols.en_cols_val[col].ec_value.ec_value_val > > > -%#define ENTRY_LEN(obj, col) \ > > > - (obj)->EN_data.en_cols.en_cols_val[col].ec_value.ec_value_len > > > +%#define ENTRY_VAL(obj, col) > (obj)->EN_data.en_cols.en_cols_val[col].ec_value.ec_value_val > > > +%#define ENTRY_LEN(obj, col) > (obj)->EN_data.en_cols.en_cols_val[col].ec_value.ec_value_len > > > % > > > %#ifdef __cplusplus > > > %} > > > > > > > How does unwrapping these lines so that they're longer than the style(9) > > limits fix the build? > > > > (I'm not a fan of 80-column limits, it's a rule that needs to die die > > die. I'm just curious what the actual fix is here.) > > > > to be honnest here I don't know how rpcgen passes lines to cpp but recent > GNU cpp > are failing because of that, looking at dragonfly I have seen they fixed > the > same way. > rpcgen accpets cpp syntax for including other snippets as rpcgen input, but also needs to keep the ability to output cpp directives in the generated code. The '%' prefix is a sigil that the directive is to be skipped by rpcgen and instead emitted to the generated code. I assume that there was a bug in the handling of continuation lines in this context which causes things to be confused, but don't know the details of that, just what's "supposed to be" going on. -Ben