From owner-svn-src-stable@FreeBSD.ORG Fri Jun 11 08:23:24 2010 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9153C10656BC; Fri, 11 Jun 2010 08:23:24 +0000 (UTC) (envelope-from rpaulo@freebsd.org) Received: from karen.lavabit.com (karen.lavabit.com [72.249.41.33]) by mx1.freebsd.org (Postfix) with ESMTP id 4F5088FC17; Fri, 11 Jun 2010 08:23:23 +0000 (UTC) Received: from e.earth.lavabit.com (e.earth.lavabit.com [192.168.111.14]) by karen.lavabit.com (Postfix) with ESMTP id B024811B84F; Fri, 11 Jun 2010 02:50:19 -0500 (CDT) Received: from 10.0.10.3 (54.81.54.77.rev.vodafone.pt [77.54.81.54]) by lavabit.com with ESMTP id IQKODBH7A5DV; Fri, 11 Jun 2010 02:50:19 -0500 Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii From: Rui Paulo In-Reply-To: <3BE36947-BCB4-4A6D-9040-873CFD144F3B@gsoft.com.au> Date: Fri, 11 Jun 2010 08:50:16 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <7E348ECC-5F60-4788-99F5-4B8D88E3AF65@freebsd.org> References: <201006102034.o5AKYMXX058081@svn.freebsd.org> <3BE36947-BCB4-4A6D-9040-873CFD144F3B@gsoft.com.au> To: "Daniel O'Connor" X-Mailer: Apple Mail (2.1078) Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: SPOOFED: Re: svn commit: r209011 - stable/8/sys/dev/ath/ath_hal/ar5211 X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2010 08:23:24 -0000 On 11 Jun 2010, at 02:46, Daniel O'Connor wrote: >=20 > On 11/06/2010, at 6:04, Rui Paulo wrote: >> Log: >> MFC r208644: >> Due to the way HALDEBUG() is defined, we need to add curly brackets >> when using it as a sole if clause instruction. >> While there, fix 'const static' typo. >=20 > Why not fix HALDEBUG? ie wrap it in do { } while (0) >=20 > Although that said when I looked at HALDEBUG on 8.0 it was defined as = a function so it is a non issue there. >=20 > HAL_DEBUG is different but I can't actually find where that is = defined. There's actually no problem in the code. This was to shut up a compiler = warning on NetBSD. I probably should've said that in the commit log. Regards, -- Rui Paulo