Date: Sun, 16 Apr 2017 09:45:01 -0400 From: Diane Bruce <db@db.net> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Kyle Evans <bsdports@kyle-evans.net>, Diane Bruce <db@freebsd.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r436814 - in head/comms: . direwolf direwolf/files Message-ID: <20170416134501.GA95743@night.db.net> In-Reply-To: <20170416132550.GA59810@FreeBSD.org> References: <201703241401.v2OE1nwY023666@repo.freebsd.org> <20170325014740.GC54562@FreeBSD.org> <CACNAnaFhG=WufG3VP3TG6CZWf507X=OFWzif2YUm8==JDKEuGg@mail.gmail.com> <20170325023517.GA18367@FreeBSD.org> <CACNAnaGdOSmZY58oE6z8P2kHO6NaNUx4-geurbteH45bLe9f7w@mail.gmail.com> <20170325024900.GC18367@FreeBSD.org> <20170416132550.GA59810@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Apr 16, 2017 at 01:25:50PM +0000, Alexey Dokuchaev wrote: > On Sat, Mar 25, 2017 at 02:49:00AM +0000, Alexey Dokuchaev wrote: > > On Fri, Mar 24, 2017 at 09:39:15PM -0500, Kyle Evans wrote: > > > ... > > > Oy, I actually didn't because all of the other directories I cared > > > about were in MAKE_ENV, and I was looking for STAGEDIR specifically. > > > > > > Attached is a revised patch, s/STAGEDIR/DESTDIR/ and the dw-start.sh > > > script was getting installed with the wrong permissions because I > > > overlooked the fact it's installed in the examples/ with a bunch of > > > datafiles. > > > > LGTM, but I'm sleepy and fainting away. Let's let Diane to review > > and handle it as it was their commit in the first place. > > Diane, do you plan to do anything about it? The port had been in pretty > bad shape for well over a fortnight now, with patches pending. I guess I was waiting for a PR to fix this or thought it had been handled already. It's in poudriere now. I'll commit when it passes. Thanks for the heads up > > ./danfe > -- - db@FreeBSD.org db@db.net http://www.db.net/~db
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170416134501.GA95743>