From owner-cvs-all@FreeBSD.ORG Sun Mar 7 16:52:43 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2DBA716A4CE; Sun, 7 Mar 2004 16:52:43 -0800 (PST) Received: from cs.rice.edu (cs.rice.edu [128.42.1.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0A48D43D1D; Sun, 7 Mar 2004 16:52:43 -0800 (PST) (envelope-from alc@cs.rice.edu) Received: from localhost (calypso.cs.rice.edu [128.42.1.127]) by cs.rice.edu (Postfix) with ESMTP id 9653D4AA99; Sun, 7 Mar 2004 18:52:42 -0600 (CST) Received: from cs.rice.edu ([128.42.1.30]) by localhost (calypso.cs.rice.edu [128.42.1.127]) (amavisd-new, port 10024) with LMTP id 29727-01-8; Sun, 7 Mar 2004 18:52:42 -0600 (CST) Received: by cs.rice.edu (Postfix, from userid 19572) id 3F6224AA77; Sun, 7 Mar 2004 18:52:42 -0600 (CST) Date: Sun, 7 Mar 2004 18:52:42 -0600 From: Alan Cox To: Peter Wemm Message-ID: <20040308005242.GG21071@cs.rice.edu> References: <200403080027.i280RXIC041557@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200403080027.i280RXIC041557@repoman.freebsd.org> User-Agent: Mutt/1.3.28i X-Virus-Scanned: by amavis-20030616-p7 at cs.rice.edu cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 vm_machdep.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Mar 2004 00:52:43 -0000 On Sun, Mar 07, 2004 at 04:27:33PM -0800, Peter Wemm wrote: > peter 2004/03/07 16:27:33 PST > > FreeBSD src repository > > Modified files: > sys/i386/i386 vm_machdep.c > Log: > Other parts of the tree do not protect calls to kmem_free() with Giant, > so remove it from here. The most notable examples include vm_mmap(). > This removes one more Giant event from exit(2). > > Revision Changes Path > 1.226 +0 -2 src/sys/i386/i386/vm_machdep.c Whether this is safe depends on whether the underlying pages need to be unwired. An explanation can be found in uma_large_free(). Unwiring dips into the pmap, acquiring Giant before doing so. The consequences would be a LOR, but not a race. Alan