From owner-freebsd-fs@FreeBSD.ORG Sat Mar 21 17:13:09 2015 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 33316DE4 for ; Sat, 21 Mar 2015 17:13:09 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 98ECAEC2 for ; Sat, 21 Mar 2015 17:13:08 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t2LHD3hG063580 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 21 Mar 2015 19:13:03 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t2LHD3hG063580 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id t2LHD3jJ063579; Sat, 21 Mar 2015 19:13:03 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 21 Mar 2015 19:13:03 +0200 From: Konstantin Belousov To: Chris Torek Subject: Re: leftovers in fs/msdosfs/msdosfsmount.h Message-ID: <20150321171303.GL2379@kib.kiev.ua> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: freebsd-fs@freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Mar 2015 17:13:09 -0000 On Thu, Mar 19, 2015 at 08:49:33PM -0700, Chris Torek wrote: > I was poking at the kernel-side msdosfs code for reasons too boring :-) to > go into here and found some stuff that should be safe to remove, based on > the fact that there are no references to these names anywhere in the rest > of the entire source tree. > > I've built a kernel with this patch in it (as a double check) but have not > tested it on anything else. I don't really care if it goes in or not, I'm > just providing it since I got misled slightly (in terms of how the UTF-16 > en- and de-coding was to be done) when I was looking at the header. > > (In case gmail eats the straight text patch below, it's here as an > attachment too. I'd send from a better mail system but my regular home > FreeBSD system is still not quite up yet...) I started the make universe for your patch, will commit after. > > (A more interesting question is: when can the old compat mount stuff go > away?) I did the review of the cmount() usage in the base, and I think now it is the autofs(4) author who is in charge. It seems that the only user of cmount in base is amd, and it should be removed, after autofs is mature enough.