Date: Thu, 09 May 2019 08:01:24 +0000 From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 237714] [PATCH] sysutils/xfce4-power-manager: fix craches, improve freebsd support, add DEBUG option Message-ID: <bug-237714-28711-SEBDi6lL0h@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-237714-28711@https.bugs.freebsd.org/bugzilla/> References: <bug-237714-28711@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237714 --- Comment #4 from Guido Falsi <madpilot@FreeBSD.org> --- (In reply to Guido Falsi from comment #3) > What I was criticizing is adding a "DEBUG" option using the options > framework. It's better to only check for the WITH_DEBUG flag and act based > on that, no need for an option in the option framework. Should every sing= le > port have a DEBUG option then? Ti make this point clearer. WITH_DEBUG should not be set by a port option, but should be manually set in make.conf. Some time ago I sent a review proposing to retire WITH_DEBUG and use a prop= er silent option for that. I was discouraged, exactly for the same reasons I'm stating I got convinced about that reasoning. Rif: https://reviews.freebsd.org/D15773 --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-237714-28711-SEBDi6lL0h>