Date: Wed, 3 Feb 2016 18:53:52 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: Ian Lepore <ian@freebsd.org> Cc: freebsd-hackers@freebsd.org, Allan Jude <allanjude@freebsd.org> Subject: Re: syslogd(8) with OOM Killer protection Message-ID: <CAOfEmZg8PZZUZUOMKPoKX7wyr3%2BJQ72AG9Rf%2ByvpENpsjXk2Dg@mail.gmail.com> In-Reply-To: <1453903686.42081.32.camel@freebsd.org> References: <CAOfEmZgzL2Ldu53CeSsKcUe00H1VAukhEopSUmpUK0=XAhsD1A@mail.gmail.com> <56A86D91.3040709@freebsd.org> <1453903686.42081.32.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Thanks everybody for the feedback! So here is a potential patch that covers what we did talk here already: https://reviews.freebsd.org/D5176 Note that I'm still making more tests and this patch is not ready to be used in production. Basically we can add oom protection doing: syslogd_oomprotect="Yes" where it will protect only the main processes. Or syslogd_oomprotect="All" where it will protect all future children of the specified processes. Best. On Jan 27, 2016 10:08 PM, "Ian Lepore" <ian@freebsd.org> wrote: > On Wed, 2016-01-27 at 02:11 -0500, Allan Jude wrote: > > On 2016-01-27 01:21, Marcelo Araujo wrote: > > > Hi guys, > > > > > > I would like to know your opinion about this REVIEW[1]. > > > The basic idea is protect by default the syslogd(8) against been > > > killed by > > > OOM with an option to disable the protection. > > > > > > Some people like the idea, other people would prefer something more > > > global > > > where we can protect any daemon by the discretion of our choice. > > > > > > Thoughts? > > > > > > > > > [1] https://reviews.freebsd.org/D4973 > > > > > > > > > Best, > > > > > > > I do like the idea of generalizing it, say via rc.subr > > > > So you can just do: > > > > someapp_protect=YES (and maybe syslogd has this enabled by default in > > /etc/defaults/rc.conf) and it prefixes the start command with protect > > -i. > > > > Maybe the setting could be named *_oomprotect to make it clear what > kind of protection is being configured? > > -- Ian > > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZg8PZZUZUOMKPoKX7wyr3%2BJQ72AG9Rf%2ByvpENpsjXk2Dg>