From nobody Mon May 8 17:56:24 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QFTVw5mKvz4BBck for ; Mon, 8 May 2023 17:56:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QFTVw4Mlkz3sFC for ; Mon, 8 May 2023 17:56:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683568584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uUz5G3EgGkwhlz6AAFTMO/K6L6trHWm0An5WBvI/HaQ=; b=QWVuKmXZgsYYmNiCH6ZHgNvN2fRJ5dw5hN55lLtKiBonudNz4+FTlwQWBhNscglBjNFnBa tZy81kdr9r6VrPwFL8avoTSegBahWVCNDGma0SGuE/G2HxGfvqA5AEY0l7+wirWQGqT4dP Ffsrl+6RMJq7yRV+xOh2UmtwIaL3sr0NfDragvtV4lhkVTud7syqrSYXvgzzJ0SnI90sW5 La1YOMA3UEsQqRZPxvKnTRpBFtGU2yQSLoQfjvuSHca8XCevpf70+3f3hQ3PLVOr2A1uQu TRrG+nPRO7/MrPYPmfreuF4JaL8+ErGH4wUM9ZsOIV+6o4ckD01JyyaW/Fs6fw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683568584; a=rsa-sha256; cv=none; b=LdnbhzZoDYu3bXCwC6ds9GuW8Y8dw1QSpiCRBqZZdgpr0hT3pMVOxF/I1yv8/tGZfUmMa5 rjtiF+KoaFpchR1t4uxpOtJDiCfyFvX7/UetkUEVIAO78yAgZZ7GjsB41pGrdb2qfM+FLD fSaLIehX0Cay5lbVKh0HFDC2ukuM+wxqkmsb5uBgbjc4axXpEU04deKR9Vb7OZ+kt14+4X +qxzUBgHk8G/T5f29Me8g+PeJvKU+XddTYZTQa46cTYHV6BiIUV8UQffzAB2Q3Z0nPNL/A SHRTjogFp89f+S46GqCwAJBVNTDR85Qeyi/KhkmSxcCbpw7zYioVpwfYgl2IiQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QFTVw3Ryyz18mJ for ; Mon, 8 May 2023 17:56:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 348HuO8M007140 for ; Mon, 8 May 2023 17:56:24 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 348HuOPe007139 for bugs@FreeBSD.org; Mon, 8 May 2023 17:56:24 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 271287] etcupdate silently installs empty files / unhandled error in install_new() Date: Mon, 08 May 2023 17:56:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: 000.fbsd@quip.cz X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271287 --- Comment #5 from Miroslav Lachman <000.fbsd@quip.cz> --- (In reply to John Baldwin from comment #4) Yes. Maybe use better wording in the panic message to tell the user "This f= ile is broken now, you must fix it manually" too.=20 Thinking about it again, this kind of error message fits this specific case only but the cp can fail for many other reasons - /etc/ can be read only - = and in this case the target file will be intact but user still need to know tha= t cp failed. The biggest problem now is that etcupdate do not show any errors from the c= p. I was not noticed about anything and ended up with more than 80 files broken. If etcupdate stop on the first copy error, tell the user "Houston, we have a problem", then user can take some actions to fix it before reboot. --=20 You are receiving this mail because: You are the assignee for the bug.=