From owner-svn-ports-head@freebsd.org Sat Jul 27 05:51:32 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E1179B172C; Sat, 27 Jul 2019 05:51:32 +0000 (UTC) (envelope-from tobik@freebsd.org) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7ECDA6C2C5; Sat, 27 Jul 2019 05:51:32 +0000 (UTC) (envelope-from tobik@freebsd.org) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id F3007554; Sat, 27 Jul 2019 01:51:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sat, 27 Jul 2019 01:51:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=5Zp6+H k3OZuzzUo7Xiss9BVRtF8xEmFC2qZN593FSxg=; b=fFHK0tzNqIXnzD5xAazmTM CX3KOaB6Q6AczoF6H2pih+xFj7Cxt0qi3MfbbNRQEq3nCs9xGXD19wl7zf5WZ0ZV Oth0J1jVSpusonIYWVRcB5mBy3iW0kg6WoAkhXQw1TxIavWhrzFID+PLYdcP4zbM b5umsPgpglWF11F/AbQLqBCBi2FVnkB05kAbnLGxDG+UzBG/HpC1HUVXVyAtorkF 4cyTKzFaxzEpIoW/fRWsql0PGodV6aa+SngQ5bWvsBE+eb77u+CAfz5NmJA8Qe6f fsy/SihXNjQEjR+SwEdwfb3kzMZ0eyX+TwW/QU/B4gdd32TDBXH6Ehj2gjHIwpQA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrkeehgddutddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujggfsehgtd erredtredvnecuhfhrohhmpefvohgsihgrshcumfhorhhtkhgrmhhpuceothhosghikhes fhhrvggvsghsugdrohhrgheqnecuffhomhgrihhnpehfrhgvvggsshgurdhorhhgnecukf hppeelhedrledtrddvvdeirdefieenucfrrghrrghmpehmrghilhhfrhhomhepthhosghi khesfhhrvggvsghsugdrohhrghenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from urd.tobik.me (ip5f5ae224.dynamic.kabel-deutschland.de [95.90.226.36]) by mail.messagingengine.com (Postfix) with ESMTPA id 8281A380074; Sat, 27 Jul 2019 01:51:23 -0400 (EDT) Date: Sat, 27 Jul 2019 07:51:21 +0200 From: Tobias Kortkamp To: Gleb Popov Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r507361 - head/Mk/Uses Message-ID: <20190727055121.GA99138@urd.tobik.me> References: <201907261652.x6QGqoxC018196@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lrZ03NoBR/3+SXJZ" Content-Disposition: inline In-Reply-To: <201907261652.x6QGqoxC018196@repo.freebsd.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 7ECDA6C2C5 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.95 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.953,0]; ASN(0.00)[asn:11403, ipnet:64.147.123.0/24, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jul 2019 05:51:33 -0000 --lrZ03NoBR/3+SXJZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 26, 2019 at 04:52:50PM +0000, Gleb Popov wrote: > Author: arrowd > Date: Fri Jul 26 16:52:49 2019 > New Revision: 507361 > URL: https://svnweb.freebsd.org/changeset/ports/507361 >=20 > Log: > Add support for USES=3D cabal:hpack and document this option. >=20 > Modified: > head/Mk/Uses/cabal.mk >=20 > Modified: head/Mk/Uses/cabal.mk > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/Mk/Uses/cabal.mk Fri Jul 26 16:46:46 2019 (r507360) > +++ head/Mk/Uses/cabal.mk Fri Jul 26 16:52:49 2019 (r507361) > @@ -2,9 +2,13 @@ > # > # Provide support for building Haskell packages using Cabal. > # > -# Feature: cabal > -# Usage: USES=3Dcabal > +# Feature: cabal > +# Usage: USES=3Dcabal or USES=3Dcabal:ARGS > +# Valid ARGS: hpack > # > +# hpack: The port doesn't have a .cabal file and needs devel/hs-hpack to > +# generate it from package.yaml file > +# > # Variables, which can be set by the port: > # > # USE_CABAL List of Haskell packages required to build a port. > @@ -36,10 +40,6 @@ > .if !defined(_INCLUDE_USES_CABAL_MK) > _INCLUDE_USES_CABAL_MK=3D yes > =20 > -.if !empty(cabal_ARGS) > -IGNORE=3D Incorrect 'USES=3D cabal:${cabal_ARGS}' cabal takes no argume= nts > -.endif > - Nothing checks USES=3Dcabal args now and it accepts any garbage arguments like USES=3Dcabal:asdfasd. Please put back some check for invalid arguments. Index: Mk/Uses/cabal.mk =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- Mk/Uses/cabal.mk (revision 507380) +++ Mk/Uses/cabal.mk (working copy) @@ -40,6 +40,10 @@ .if !defined(_INCLUDE_USES_CABAL_MK) _INCLUDE_USES_CABAL_MK=3D yes =20 +.if !empty(cabal_ARGS:Nhpack) +IGNORE=3D USES=3Dcabal has invalid arguments: ${cabal_ARGS:Nhpack} +.endif + PKGNAMEPREFIX?=3D hs- =20 EXECUTABLES?=3D ${PORTNAME} --lrZ03NoBR/3+SXJZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAl075lVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2HpBAf/RTLrbl2k/OQcukBu7ySD7QkTygaOxFRN1TmffC4sGLvsPZ5nhJZUhW2s +nO0QYck+kbYXecLfpZ3gfeCP/eoXA4myWwWEMbbOLnxkP5pQIKx1PBciLysJyoq IrU0SUohbJXNzaUabXqnJCZQ5QkN1CqY3ySY+FkiYVqKa9wZquxacYJ834CwyFuh jQhSxPCcrG1mTBiTxDvKqnt2EdFySaCka/6kBDXm0rfLWYl9ZunGaXKG0N4hB8V1 ilcXP+1wCfXsuuUa/2R1cxY4oobsOtf+s6rIVnAjesDWh9ovywMBJ581gRYCIqQT o5urWzLtWUly+svQ5y7UYbb7uhXoPw== =+lbj -----END PGP SIGNATURE----- --lrZ03NoBR/3+SXJZ--