From nobody Wed May 7 18:14:40 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zt3M61srcz5wYn2; Wed, 07 May 2025 18:14:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zt3M616Kzz3HpH; Wed, 07 May 2025 18:14:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746641682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ixUgCpOWvfBUGO7ldjqj9mdYjryA3oVScArQ01EBBso=; b=vGtaffuRNKoaKcUt61uEgs/j1UUqqGEwU1RWgmYLZTSlAF4u6nUkbYyByXLtcW4U/LkbcO RxsTMszjiaSElwMAm4memHAVkkC46ghLNewh+9v1xqJ5AjssQZ0PfiuyEVGudaAUfCMT5n 94UJy+/BLa6vxEHhHoxqyWf0M/LlDfQfyUUgTPxtOR+xhhyAavZfIEukl/beDvV3KwwAUS NON74Zm5+dEod4Lgdwxx2eFl95BwDd4Abmug7m6U4+hCi//4iUun5HVhpY3Z1CWrlumSZg RXu+MFXeQ89cheGr7YECA6Bmupcz8PcZLKnoTlEuMRCPcYL8pVZCDvmqLKEmeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746641682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ixUgCpOWvfBUGO7ldjqj9mdYjryA3oVScArQ01EBBso=; b=gYfTmOSaQBmuRJzxyW/xQ7smukM7+jBhde4MGUwl/M5lMM6t97eDnMZR5bC5NFgGEzY33H QtbdB5d1QDDc16uuHn32eoGhzdYgVtiVP2GNZrPP9B5ssYH2bjaGfwGn6nECySKZdt+fYY If/SCgi6vUNeo0WWWPBVGnyTN29egVigcht7qBmaBGZ/cJ+9MVRIUx9CGug9fw/FmFH6tm mRSb3wNaYNOQnu5NHEIrQKSzp12pYutK3sGUSzYjIx+uzwTDxES5qBzwBkEPMZQsZKvfTT j5P0mMqBCEePkkLiSmuQyFb0ESiK+xuJF7SL/Kb25wFK7TaWR1T+AOiS17vIJA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746641682; a=rsa-sha256; cv=none; b=t1UbQNZ5FZ0tfGi3sa9MYQoyiugyDzFPeUYcCb+KZSev84d9ObJkBWRBEfDEO3mLl+ep9y ruYumh9W2NJaKX4xpJ5fdLZGxDblXa50/l1ce45+lAu80rZK2v2akUUsGjwI2W6s/VA7V9 FZyn228+UIoQtzLfl/DDb+6Z7AWV5pIr38xXTY5/z/FqoOC3VrjsV56cf+Kv4jmuZwpi2W Zxge/QiD8UFdO87hWWxu+qVWNk7wv8U74Id1SSyxOI7trNgl3EivHs4zJ/vukeWDOAqC+U ti7UKye6OrH8Cz+BFN18z69InDtvAbCV55jDsartrFWhDGZGC3P4DLiBP2TeRg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2601:5c0:4200:b830:a58c:2073:452d:c9f2] (unknown [IPv6:2601:5c0:4200:b830:a58c:2073:452d:c9f2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Zt3M55SBwzCrp; Wed, 07 May 2025 18:14:41 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <175576a0-78fc-4d5f-a3f4-f940d083dec8@FreeBSD.org> Date: Wed, 7 May 2025 14:14:40 -0400 List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 154ccb0196cd - stable/14 - ps(1): Update some options' conformance/practice comments Content-Language: en-US To: Warner Losh , Olivier Certner Cc: "Piotr P. Stefaniak" , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org References: <202505011951.541JpiQV068751@gitrepo.freebsd.org> <2988597.slGk94SIus@ravel> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/5/25 09:29, Warner Losh wrote: > On Mon, May 5, 2025, 6:13 AM Olivier Certner wrote: > >>>> - /*- >>>> + /* >>> >>> No opinion on which it should be, but the minus character is meaningful >>> within the context of indent(1) - it won't reformat "block" comments. >> >> Thanks for pointing that out, I didn't know. I think removing them was >> OK, as these block comments are really nothing special. Actually, I >> probably should have reformatted them to eliminate the margin for all but >> the first line. >> > > Almost nobody uses indent these days on a regular basis. We can drop it for > that reason alone, even if the comments were formatted by hand... we likely > need to start tagging those with clang format tags.. Eh, the clang format tags are ugly for this use case. If using CommentPragmas doesn't already handle this case, I'd rather add a new option to clang-format to disable reflowing comments when this is present. We already have this widely used throughout the tree, and it would better to fix the tool than gratuitous churn. We probably clear clang-format's bar of being a project of a sufficient size that they will accept patches from us for new formatting options. -- John Baldwin