From owner-svn-src-all@freebsd.org Sat Aug 12 16:57:41 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B436DD93620; Sat, 12 Aug 2017 16:57:41 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-pg0-f44.google.com (mail-pg0-f44.google.com [74.125.83.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8EE9B681FF; Sat, 12 Aug 2017 16:57:41 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: by mail-pg0-f44.google.com with SMTP id v77so26473135pgb.3; Sat, 12 Aug 2017 09:57:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=VhR92VbNFOvyGUQmoqImmA6Aq6yT5mnaXSghQ0cZGPM=; b=ksTNz+hKAfN6Iu+CDalg8IS8aueTjNUk+EuqE2Tand4o0lsK7LqdgVftDqiN5wBOGA MFRsUlnkn11XLj8jgtDaoPCR29vnii0oT9pNRTHbqM3RKWJ/7o0tiB76GNh6Fd+gXF6K UU3vWanNKHy9O494TjG1i9bjSjdEv0QfFh2fUFkOBvyW5gbcq6EzIsS7NvQeecdMmzAu LiWyBcB8cthmuxhQKuucY+VZ9llB12L4hHFE/ZbEXd5+DzJ8dbVhpjooKe/81E1pZbdk m2STP3cjfv6kcow6qIRu8/0B5jXnCQeZODaWgK/EUrxszE5viajiP+OkhPT7ql4gNyAq T2rw== X-Gm-Message-State: AHYfb5jDN0b8VQtOsQVggAGTwMMRwxaKDNn1uYyRDz+0h6cdHqA2a7qJ +6+KYrAUbksM1pkQ8ck6Ig== X-Received: by 10.98.198.145 with SMTP id x17mr20199330pfk.272.1502557054862; Sat, 12 Aug 2017 09:57:34 -0700 (PDT) Received: from mail-pf0-f181.google.com (mail-pf0-f181.google.com. [209.85.192.181]) by smtp.gmail.com with ESMTPSA id f15sm7228583pfj.127.2017.08.12.09.57.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Aug 2017 09:57:34 -0700 (PDT) Received: by mail-pf0-f181.google.com with SMTP id t86so27034684pfe.2; Sat, 12 Aug 2017 09:57:33 -0700 (PDT) X-Received: by 10.99.96.67 with SMTP id u64mr18496115pgb.424.1502557053761; Sat, 12 Aug 2017 09:57:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.207.193 with HTTP; Sat, 12 Aug 2017 09:57:33 -0700 (PDT) In-Reply-To: <1502555191.47886.30.camel@freebsd.org> References: <201708112241.v7BMfP5X028262@repo.freebsd.org> <1502555191.47886.30.camel@freebsd.org> From: Ryan Libby Date: Sat, 12 Aug 2017 09:57:33 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r322418 - head/lib/msun/src To: Ian Lepore Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Aug 2017 16:57:41 -0000 On Sat, Aug 12, 2017 at 9:26 AM, Ian Lepore wrote: > On Fri, 2017-08-11 at 22:41 +0000, Ryan Libby wrote: >> Author: rlibby >> Date: Fri Aug 11 22:41:24 2017 >> New Revision: 322418 >> URL: https://svnweb.freebsd.org/changeset/base/322418 >> >> Log: >> lib/msun: avoid referring to broken LDBL_MAX >> >> LDBL_MAX is broken on i386: >> https://lists.freebsd.org/pipermail/freebsd-numerics/2012-September >> /000288.html >> >> Gcc has produced +Infinity for LDBL_MAX on i386 and amd64 with -m32 >> for some time, and newer versions of gcc are now warning that the >> "floating constant exceeds range of 'long double'". Avoid this by >> referring to half the value of LDBL_MAX instead. >> >> Reviewed by: bde >> Approved by: markj (mentor) >> Sponsored by: Dell EMC Isilon >> > > I now get this error when building toolchain for sparc: > > cc -isystem /b/staging/freebsd/head/obj/sparc64.sparc64/b/staging/freebsd/head/src/tmp/usr/include -L/b/staging/freebsd/head/obj/sparc64.spar > c64/b/staging/freebsd/head/src/tmp/usr/lib -B/b/staging/freebsd/head/obj/sparc64.sparc64/b/staging/freebsd/head/src/tmp/usr/lib --sysroot=/b/ > staging/freebsd/head/obj/sparc64.sparc64/b/staging/freebsd/head/src/tmp -B/b/staging/freebsd/head/obj/sparc64.sparc64/b/staging/freebsd/head/ > src/tmp/usr/bin -fPIC -DPIC -g -O2 -pipe -I/b/staging/freebsd/head/src/lib/msun/ld128 -I/b/staging/freebsd/head/src/lib/msun/sparc64 -I/b/sta > ging/freebsd/head/src/lib/msun/src -I/b/staging/freebsd/head/src/lib/libc/include -I/b/staging/freebsd/head/src/lib/libc/sparc64 -MD -MF. > depend.catrigl.pico -MTcatrigl.pico -std=gnu99 -fstack-protector-strong -Wsystem-headers -Werror -Wno-pointer-sign -Wno-unknown-pragmas - > c /b/staging/freebsd/head/src/lib/msun/src/catrigl.c -o catrigl.pico > /b/staging/freebsd/head/src/lib/msun/src/catrigl.c:310:1: error: pasting "0x0.8p" and "(" does not give a valid preprocessing token > /b/staging/freebsd/head/src/lib/msun/src/catrigl.c:310:1: error: exponent has no digits > /b/staging/freebsd/head/src/lib/msun/src/catrigl.c:310:1: error: pasting ")" and "L" does not give a valid preprocessing token > /b/staging/freebsd/head/src/lib/msun/src/catrigl.c: In function 'clog_for_large_values': > /b/staging/freebsd/head/src/lib/msun/src/catrigl.c:310: error: expected ')' before 'L' > *** [catrigl.pico] Error code 1 Thanks, I see it. It also shows up on the sparc64 ci build [1]. Let me see if I can find a quick fix, else I guess we can just back it out for now. [1] https://ci.freebsd.org/job/FreeBSD-head-sparc64-build/2534/