From owner-svn-src-head@FreeBSD.ORG Wed Apr 4 19:36:17 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EA0B31065675; Wed, 4 Apr 2012 19:36:17 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id BD8908FC0A; Wed, 4 Apr 2012 19:36:17 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 39358B95F; Wed, 4 Apr 2012 15:36:17 -0400 (EDT) From: John Baldwin To: Julian Elischer Date: Wed, 4 Apr 2012 15:35:57 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p10; KDE/4.5.5; amd64; ; ) References: <201203311120.q2VBKmJT099513@svn.freebsd.org> <201204040757.42452.jhb@freebsd.org> <4F7CA1CA.8070602@freebsd.org> In-Reply-To: <4F7CA1CA.8070602@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201204041535.57453.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 04 Apr 2012 15:36:17 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Gleb Smirnoff , src-committers@freebsd.org Subject: Re: svn commit: r233745 - head/sys/netinet/ipfw X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2012 19:36:18 -0000 On Wednesday, April 04, 2012 3:32:26 pm Julian Elischer wrote: > On 4/4/12 4:57 AM, John Baldwin wrote: > > On Tuesday, April 03, 2012 7:46:56 pm Julian Elischer wrote: > >> On 3/31/12 4:20 AM, Gleb Smirnoff wrote: > >> > >> > >> Many years ago there was the possibility that malloc M_WAITOK could > >> return on shutdown or in some other rare error cases. > >> > >> Are we certain this is no longer true? > > That hasn't been true in a long while. In edge cases malloc() with M_WAITOK > > will just panic rather than return NULL. (e.g. "kmem too small") > > > what happens if you call reboot while it is waiting for free space? The same thing that happens to any other thread asleep when we reboot, they eventually die one way or another when the CPU resets. If it happens to be a user thread that doesn't respond to kill then you get a warning about not all processes dying during shutdown, but that's about it. -- John Baldwin