From owner-freebsd-current@FreeBSD.ORG Mon Oct 31 21:15:37 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0AF3A16A41F for ; Mon, 31 Oct 2005 21:15:37 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8EF5E43D45 for ; Mon, 31 Oct 2005 21:15:36 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [10.50.41.234] (Not Verified[10.50.41.234]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Mon, 31 Oct 2005 16:32:29 -0500 From: John Baldwin To: current@freebsd.org Date: Mon, 31 Oct 2005 17:17:12 -0500 User-Agent: KMail/1.8.2 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200510311717.13419.jhb@freebsd.org> Cc: Subject: [PATCH] push Giant down into fdfree() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Oct 2005 21:15:37 -0000 This patches pushes Giant down into fdfree() by using VFS_LOCK_GIANT for the occasional VOP_ADVLOCK() and moving various vrele() calls out from under the FILEDESC_LOCK. Note that about half the calls to fdfree() (either directly or indirectly via fdunshare()) didn't lock Giant anyway. Please review and/or test, thanks! http://www.FreeBSD.org/~jhb/patches/fdfree.patch -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org