From nobody Sat Mar 25 13:27:17 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PkKck2b6rz41BKk; Sat, 25 Mar 2023 13:27:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PkKck1SnNz3t9t; Sat, 25 Mar 2023 13:27:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679750838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=V1bEgiEc8KLfftCct09sSnJbp/WrIyjou0y5a2RQ3Ao=; b=E54YoG3k3uBxegn+bkkjmcGUXxRYTbMJuByLfGgsm1wQtAfSjmWh07sP8M07QmBKWtxy48 ZKzuXTOsFX7f1oTUfEM8lsiAbBZM3TGuscXGQDAOiDnHRAlnz172ke1sudq9iImBn4abTN rZn80IAR4qgndyHB5qQQfAOUGeG8MSfEEqwXEe4ym0cc0OVciMccLYimndsKUMaKkbYyQE w0WmwVnI91VJotTa+FsXOgt44aSNpepkFYHSQU0/j3E7Q6CNVEnH17bLh82qSrZwd7wu7P 0kr87SaKbecriCtrEr5XxmRgHPgTBR73nxOHD41UWIZjRptjC/uo2A7WXWLPIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679750838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=V1bEgiEc8KLfftCct09sSnJbp/WrIyjou0y5a2RQ3Ao=; b=HboHAbmGPCZsvqkE+qqyWUQWCzhONWUXU5pjx+3CUO3eDmZYUt18BRoHP4ZiO0lWKKyRr/ T+tU0dGG8J3GD6mwUP4QsjUfQ0+OGbchetkLHNgwuY6j+2SNPFF9076fgIJypHhoRyhjvZ A19+QpIe+V3PqjA1rfF0zH3Y7LfPP5aadJr+ZMjjvs6KJ8TAo28OM0WgdzKXjDftW39nXr WPP8qf+z3BFIE+tLqOWHkthXm8F9DXcwdEAUH26/3qkKdC/LwPT4KE46KroGNl26s2/v0U xKL+/FzT4VeFg1M1YmRFBIMgW1dVA34OCfOE+h7ZP5zOx8XJq33r9Gs4zowSdA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679750838; a=rsa-sha256; cv=none; b=Td1ti0RwVJs2+O3wIFqBZZBHk8vAvwUUXYaYQWXxZ7TiZiF19kgiqtzWd3lWKjwl9q377q quKWqYtkDH6Spy3bacA1DcF4do3k+1qYODNckEWamrDRg8pdK/Pp7hyoDP6gsZbmJ15ujX 0p+AGhkDhbmrQW2FgjuGw7z2eulf7zAZGVPGJl5Jse2k8g2cQu7M0byvhs3CXo4hvHp4OY sKVnsyZmRr8avUmNEZdGk82lsqhgEThNW9IEd966VJ+OWKpo0czwn9RNIt6VhH5Sx59KD9 M+zb/fYzTM2TkDfXUt1SoAw653GduZ3Z4Y9am7aGeLaxSbk5yFqA57Df9fmvug== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PkKck0Sqxz112k; Sat, 25 Mar 2023 13:27:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 32PDRHIU017135; Sat, 25 Mar 2023 13:27:17 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 32PDRHsk017134; Sat, 25 Mar 2023 13:27:17 GMT (envelope-from git) Date: Sat, 25 Mar 2023 13:27:17 GMT Message-Id: <202303251327.32PDRHsk017134@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 978013a0945d - main - makefs: emit NM records for all directory entries List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 978013a0945d4c6b7ab3ee798dc13c74e913762a Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=978013a0945d4c6b7ab3ee798dc13c74e913762a commit 978013a0945d4c6b7ab3ee798dc13c74e913762a Author: Ed Maste AuthorDate: 2023-03-24 17:53:59 +0000 Commit: Ed Maste CommitDate: 2023-03-25 13:25:18 +0000 makefs: emit NM records for all directory entries We previously attempted to emit Rock Ridge NM records only when the name represented by the Rock Ridge extensions would actually differ. We would omit the record for an all-upper-case directory name, however Linux (and perhaps other operating systems) map names with no NM record to lowercase. This affected only directories, as file names have an implicit ";1" version number appended and thus always differ. To solve, just emit NM records for all entries other than DOT and DOTDOT . We could continue to omit the NM record for directories that would avoid mapping (for example, one named 1234.567) but this does not seem worth the complexity. PR: 203531 Reported by: Thomas Schmitt TEST, - * no NM. test -> TEST, need a NM - * - * The rr_moved_dir needs to be assigned a NM record as well. - */ if (node == diskStructure->rr_moved_dir) { cd9660_rrip_add_NM(node, RRIP_DEFAULT_MOVE_DIR_NAME); - } - else if ((node->node != NULL) && - ((strlen(node->node->name) != - (uint8_t)node->isoDirRecord->name_len[0]) || - (memcmp(node->node->name,node->isoDirRecord->name, - (uint8_t)node->isoDirRecord->name_len[0]) != 0))) { + } else if (node->node != NULL) { cd9660_rrip_NM(node); } - - /* Rock ridge directory relocation code here. */ /* First handle the CL for the placeholder file. */