From nobody Sat Jun 27 02:26:28 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gnGd10JbNz6jNB8 for ; Sat, 27 Jun 2026 02:26:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gnGd06T9Jz3Ng6 for ; Sat, 27 Jun 2026 02:26:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782527188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=23nrGbg2wXAdJo+qTYkyXtEto8kyfFPcFGw5KB6qP5M=; b=Yq9wrZYxo4Dj2AvvJsuIsU31UVJwdt9q3WfmHVXZYZ6ZbRGwDZHqhleHLrwWPDR48jmm11 QDSNK2FTqaAaD+0VtrrrY5GrSVjxloqpDNQ64Qn02ml1aa4B2+7dNGEV3qcCuUXLKrTtvU hbvuDrpucUhFaHdWpgSyPNwj8pvyjpxVTumqbiYgPLlm5ReyfqX4+60bBoRrjWDdfnRcSi tQPggrpHtJk4xcdZl5snUL69Ae5WwTlMNQNDwCXfHCUCcqX/IiRXweYNkraVGCzAW46f1e Cn71m1hS1pRCwPE1YydZH/igrYQV1UM4UZCxwnRNiIywaXkPU/mxt6bx3PtT+Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782527188; a=rsa-sha256; cv=none; b=OtodbIZHMXKJpdlBqVPedsK+Hd/54dzJvqcRP7nBBUGTtfe3V0OVd2XMIa7wJ2uc+TYFSJ M6QQ+J4WohPR66T8iPLBVGqd+jhxOBWUnjL82UsT53FmBqjwXkdoXypKWuIDNLNEZt63cD u4Vlv1aNn7ZGCZCxUlViX//m2GzzR/g82eDZ0x9gdjMdl16Cm//Y3VFPESMVRxsdGSVx4D LxB/rB3pA2IYrlYvLdLXSQ8T+l+dWRcXCp9EzZJGNb6LM4R9lLy4l8EDZt92IOsUTSDrpB DXKjgcJUJPoJmyo8JQj0jxkk2OmlEqGUppBWmW5Wa0Ri9bl0MERQ3UD7qwxKzw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782527188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=23nrGbg2wXAdJo+qTYkyXtEto8kyfFPcFGw5KB6qP5M=; b=B1eB94uI1Vrh36Ss87jqGsM6aHS++D+FloITtrbwQPgt/kLoGvt/DsfOsTQH1d1xFOV1UV ztbhVCXuwZeIxyVlAVmlJcLA5gzZxOuDcm3mUSklMV4zh5KI/8mqch8eGUHk+xYEnGM6JV SdH7JZ8eoR7RDzHJ+U7fUV83wTFfG9g3botinln8wpgYpT9TLnnBWVJm05Jq0SP5PtdI6Y X6oESxlJ7qza3riXNVVq2GoYOEGbPTCUwHd2gEbwvHlBnUWqDaHAA+zNfdZQErz61IqKY2 K5BPsq/8Hn/2ghmT1f9a3kuBY05cZ03gpmH8DKFA1rItDpUDIW6+szA6V+98iA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gnGd05Drnz14hY for ; Sat, 27 Jun 2026 02:26:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 22f58 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 27 Jun 2026 02:26:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Li-Wen Hsu Subject: git: 8e61d8707f8a - main - libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: lwhsu X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8e61d8707f8a10acc143210089fea2502a3f2922 Auto-Submitted: auto-generated Date: Sat, 27 Jun 2026 02:26:28 +0000 Message-Id: <6a3f34d4.22f58.4106286d@gitrepo.freebsd.org> The branch main has been updated by lwhsu: URL: https://cgit.FreeBSD.org/src/commit/?id=8e61d8707f8a10acc143210089fea2502a3f2922 commit 8e61d8707f8a10acc143210089fea2502a3f2922 Author: Li-Wen Hsu AuthorDate: 2026-06-27 02:26:05 +0000 Commit: Li-Wen Hsu CommitDate: 2026-06-27 02:26:05 +0000 libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode dt_print_sym() fills the symbol string via snprintf() in non-oformat mode but the guarding `dtp->dt_oformat != 0 &&` for the dt_printf() call causes the symbol is computed but never emitted. This fixes tests: - common.profile-n.t_dtrace_contrib.tst_sym_ksh - common.profile-n.t_dtrace_contrib.tst_func_ksh Reviewed by: markj Fixes: 93f27766a7e1 ("dtrace: Add the 'oformat' libdtrace option") MFC after: 3 days Event: Halifax Hackathon 202606 Location: Room 208, Computer Science Building, Dalhousie University Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57895 --- cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c index b311b5425587..a8a49b22ed7b 100644 --- a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c +++ b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c @@ -2143,7 +2143,7 @@ dt_print_sym(dtrace_hdl_t *dtp, FILE *fp, const char *format, caddr_t addr) } } - if (dtp->dt_oformat != 0 && dt_printf(dtp, fp, format, c) < 0) + if (!dtp->dt_oformat && dt_printf(dtp, fp, format, c) < 0) return (-1); return (0);