From owner-freebsd-arch@FreeBSD.ORG Sat Aug 23 06:59:07 2008 Return-Path: Delivered-To: arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E08CF106566C; Sat, 23 Aug 2008 06:59:07 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 9ED168FC16; Sat, 23 Aug 2008 06:59:07 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m7N6uOTX087502; Sat, 23 Aug 2008 00:56:25 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sat, 23 Aug 2008 00:56:56 -0600 (MDT) Message-Id: <20080823.005656.1543769327.imp@bsdimp.com> To: kabaev@gmail.com From: "M. Warner Losh" In-Reply-To: <20080822213505.1993beda@kan.dnsalias.net> References: <20080729.161303.709402272.imp@bsdimp.com> <20080822213505.1993beda@kan.dnsalias.net> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: kan@FreeBSD.org, arch@FreeBSD.org, obrien@FreeBSD.org Subject: Re: Need a code review X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Aug 2008 06:59:08 -0000 In message: <20080822213505.1993beda@kan.dnsalias.net> Alexander Kabaev writes: : On Tue, 29 Jul 2008 16:13:03 -0600 (MDT) : "M. Warner Losh" wrote: : : > Greetings, : > : > The FreeBSD/mips efforts are getting close. We're down to 4 patches : > against the main tree, divided up among different programs: cc, : > binutils, libpam and the CDDL stuff for zfs. : > : > http://people.freebsd.org/~gonzo/mips2/binutils.diff : > http://people.freebsd.org/~gonzo/mips2/cc.diff : > http://people.freebsd.org/~gonzo/mips2/cddl.diff : > http://people.freebsd.org/~gonzo/mips2/libpam.diff : > : > If you have an interest in any of these area, or would like to provide : > feedback on the patches, now would be a good time to do so. :-) : > : > We'd like to commit these patches to the tree by the end of next week, : > if at all possible. If you are a maintainer of this software, we'd : > especially like to get feedback from you on these patches. If we : > don't hear back from you, we'll assume that you are fine with them :-) : > : > Warner : : cc.diff part is OK, except that files we copy from vendor intact should : be marked as such. Ideally, by putting their pristine versions : in /vendor and branching into head/src/contrib/gcc. Good idea. Now, if only I can figure out how to do that... : Some comments in new FreeBSD files still claim they are for NetBSD/mips. We can fix that :-) Good catch. : +#ifdef HANDLE_PRAGMA_PACK_PUSH_POP : +#undef HANDLE_PRAGMA_PACK_PUSH_POP : +#endif : #define HANDLE_PRAGMA_PACK_PUSH_POP 1 : : Can this be rewritten as : #ifndef HANDLE_PRAGMA_PACK_PUSH_POP : #define HANDLE_PRAGMA_PACK_PUSH_POP 1 : #endif No. The whole reason those changes were introduced was to quiet warnings that HANDLE_PRAGMA_PACK_PUSH_POP was redefined... We can omit them if they will cause problems. I wasn't real concerned about the warnings, but Randal Stewart fixed them since they bugged him. Maybe there's a better way? Any suggestions? Warner