From owner-cvs-src@FreeBSD.ORG Tue Sep 23 22:13:11 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C333016A4B3; Tue, 23 Sep 2003 22:13:11 -0700 (PDT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id D35D643FBD; Tue, 23 Sep 2003 22:13:10 -0700 (PDT) (envelope-from sam@errno.com) Received: from melange.errno.com (melange.errno.com [66.127.85.82]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.9) with ESMTP id h8O5D80x039175 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Tue, 23 Sep 2003 22:13:10 -0700 (PDT) (envelope-from sam@errno.com) Date: Tue, 23 Sep 2003 22:13:07 -0700 From: Sam Leffler To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <974136654.1064355187@melange.errno.com> In-Reply-To: <200309240508.h8O58wx0000675@repoman.freebsd.org> References: <200309240508.h8O58wx0000675@repoman.freebsd.org> X-Mailer: Mulberry/3.0.3 (Win32) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Subject: Re: cvs commit: src/sys/contrib/ipfilter/netinet ip_fil.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2003 05:13:11 -0000 > sam 2003/09/23 22:08:58 PDT > > FreeBSD src repository > > Modified files: > sys/contrib/ipfilter/netinet ip_fil.c > Log: > o remove extraneous include of > o guard wrapper code against user-mode compilation > And what I really wanted to say was: ip_fil.c is a cesspool of #ifdefs and should be used as an example of how not to write maintainable code. Sam