From owner-svn-ports-head@FreeBSD.ORG  Fri Feb 22 13:40:47 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 7B8E5F18; Fri, 22 Feb 2013 13:40:47 +0000 (UTC)
Date: Fri, 22 Feb 2013 13:40:47 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Ganael LAPLANCHE <martymac@FreeBSD.org>
Subject: Re: svn commit: r312755 - head/games/flightgear-mb339-pan
Message-ID: <20130222134047.GA22627@FreeBSD.org>
References: <201302220901.r1M91qmw094583@svn.freebsd.org>
 <20130222091442.GA69915@FreeBSD.org>
 <20130222130707.M56953@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20130222130707.M56953@FreeBSD.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Feb 2013 13:40:47 -0000

On Fri, Feb 22, 2013 at 01:10:34PM +0000, Ganael LAPLANCHE wrote:
> On Fri, 22 Feb 2013 09:14:42 +0000, Alexey Dokuchaev wrote
> > And the differences (old vs. new distfiles) were?..
> 
> Nothing special ; xml files have been converted to UTF-8 (including a
> BOM, see attached diff between previous and current version).

It's OK, you shouldn't have to attach a diff.  My point was that in these
cases, committer must 1) manually verify that no malicious changes were
inserted into new distfile, and 2) provide a summary of changes in the
commit log.

> > P.S.  I would kindly suggest reading svn-ports-all@, this issue was
> > just brought up few days ago.
> 
> Damn, I have not found this thread, would you have a pointer to give to me?

I raised similar concerns over r312399 on Feb 17, rm@ was to follow up:
http://docs.freebsd.org/cgi/mid.cgi?20130217051144.GA38688

./danfe