From owner-freebsd-mips@FreeBSD.ORG Fri Jul 30 08:15:57 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2D0021065670; Fri, 30 Jul 2010 08:15:57 +0000 (UTC) (envelope-from c.jayachandran@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 764BD8FC14; Fri, 30 Jul 2010 08:15:56 +0000 (UTC) Received: by fxm13 with SMTP id 13so756968fxm.13 for ; Fri, 30 Jul 2010 01:15:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=RRWOWHcVx7nPxmIm0phGzoASTTbhFSG8IA9KBg3Y2+g=; b=E0OvwaLn0meEQN23IGCjXFwxvN0byZZ2dFB/sQifF5vLaG7ve89WbyjuerTPE9XEk/ LAYKL9mOwi3ZyXwTn8QaeG6y3DxmjbVTNzE/5ird0TVEDS35P9GwW6F6ror3tN0ljwS+ 7Jh0xIocw1edsDqBZmy4S+oJXW2Xnsj9/eQcU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=c+u4Qd1otaMT1dpJsDwxHArTDv/1EBHp/oNZ0CBgaw9xrJxDkc88yYcLYzrB3KxU/w VEQcKLJhZsvW8oeFDYtAtgz9DDSzTxSbLlogJPYwNCOVcvr06ShTaSi2neryj67msrwb F/yNVamoE78Y5X9JS0jXdO1wylgBdOferV2xk= MIME-Version: 1.0 Received: by 10.103.239.14 with SMTP id q14mr393911mur.15.1280477754418; Fri, 30 Jul 2010 01:15:54 -0700 (PDT) Received: by 10.102.228.12 with HTTP; Fri, 30 Jul 2010 01:15:54 -0700 (PDT) In-Reply-To: <20100729.131134.4959786895411328.imp@bsdimp.com> References: <20100729.131134.4959786895411328.imp@bsdimp.com> Date: Fri, 30 Jul 2010 13:45:54 +0530 Message-ID: From: "Jayachandran C." To: "M. Warner Losh" , jmallett@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-mips@freebsd.org Subject: Re: Support for 64bit userspace. X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jul 2010 08:15:57 -0000 On Fri, Jul 30, 2010 at 12:41 AM, M. Warner Losh wrote: > In message: > =A0 =A0 =A0 =A0 =A0 =A0Juli Mallett writes: > : On Thu, Jul 29, 2010 at 01:15, Jayachandran C. wrote: > : > I kept the 32 bit pmap.c code untouched so that I don't have to deal = with > : > the breakage there during the early 64bit changes. > : > I will check in the other changes now, and will do another round of w= ork on > : > pmap.c/pmap64.c to see if it can be merged (and eliminate the config > : > option). > : > : Hmm, hopefully the changes will be well-isolated and any abstractions > : will be right for 32-bit and 64-bit both. =A0One of the problems with > : two files is that when they are merged, which it sounds like you think > : is inevitable, we lose the change history for that file. =A0And if > : they're in the same file, you don't need an option, just __mips_n64. > > I'd prefer one file as well... I will look at merging them without too many ifdefs. Another possibility is to have a pmap.c, pmap32.c and pmap64.c, so that the common code is not duplicated, but that too (as far as I can see) will require a config option. Also, I've been checking in the other pieces of 64 bit support that I had posted here. I've broken down the patches further so that they are be obvious (and easy to revert if it affects anything). I am not planning to check-in the pmap changes for 3 level page tables now, will post it again for review once I see what level of merge can be done. JC.