From owner-freebsd-current@freebsd.org  Thu Oct  6 07:40:54 2016
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A88B3AF5166
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Thu,  6 Oct 2016 07:40:54 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id C72F89B3;
 Thu,  6 Oct 2016 07:40:53 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA06654;
 Thu, 06 Oct 2016 10:40:51 +0300 (EEST)
 (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1bs3IR-0009FX-Pn; Thu, 06 Oct 2016 10:40:51 +0300
Subject: Re: [request for testing] isl, cyapa on chromebooks
To: Michael Gmelin <grembo@FreeBSD.org>
References: <1e66fc64-cdff-e94b-4b0c-55cb05e2b5a1@FreeBSD.org>
 <20161003180750.744dae0a@bsd64.grem.de>
 <ecd26145-442d-d059-59a1-139e206d451b@FreeBSD.org>
 <20161003222528.56d46787@bsd64.grem.de>
 <c1a5224f-6cef-ed9c-d795-6af3d93dc48d@FreeBSD.org>
 <20161004114635.64857a29@bsd64.grem.de>
 <d989c916-e705-ca6b-9ea6-ccc17c785a82@FreeBSD.org>
 <20161005004831.2a2fdc4b@bsd64.grem.de>
 <1bcfd282-63fd-f8ee-4dad-393b51f14bcd@FreeBSD.org>
 <302FDA6E-DEC7-49F0-8F2C-8C26C8A884AF@freebsd.org>
 <53bca4d2-975f-f4a0-d12a-5d73fba01a0c@FreeBSD.org>
 <3B8B4A4A-8583-4063-999A-780DD5867E04@freebsd.org>
 <8ed7a632-6839-52b8-6a7a-68c661f67819@FreeBSD.org>
Cc: FreeBSD Current <freebsd-current@FreeBSD.org>
From: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <decbe48c-ba49-3a21-b18c-ffb2d93eb0a3@FreeBSD.org>
Date: Thu, 6 Oct 2016 10:39:56 +0300
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <8ed7a632-6839-52b8-6a7a-68c661f67819@FreeBSD.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Oct 2016 07:40:54 -0000

On 06/10/2016 10:25, Andriy Gapon wrote:
> On 06/10/2016 10:08, Michael Gmelin wrote:
>>
>>
>>> On 05 Oct 2016, at 15:01, Andriy Gapon <avg@FreeBSD.org> wrote:
>>>
>>>> On 05/10/2016 14:19, Michael Gmelin wrote:
>>>>
>>>> ig4iic_start is called, but iicbus_hinted_child, isl_probe, iicbus_probe and
>>>> iicbus_attach are not.
>>>
>>> Thank you!
>>> Now I think I see where I made a silly mistake.
>>> Please try an updated version of the patch from here
>>> https://people.freebsd.org/~avg/ig4-i2c.v3.diff
>>> It contains a fix and some cosmetic changes on top of the previous patch.
>>>
>>
>> Isl attaches cleanly on iicbus1 now, but it doesn't appear to function (all inputs, like  dev.isl.ir etc, are stuck at 0).
> 
> At least some progress...
> Anything interesting in logs?
> 
> Oh! and I've just spotted a typo in isl.c: the last call to isl_read_byte() in
> isl_read_sensor() should have REG_DATA2 (not REG_DATA1 again).

And another, more severe typo :-(
In isl_read_byte we should pass both messages to the bus:
	return (iicbus_transfer(dev, msgs, 2));
That is, s/1/2/.

-- 
Andriy Gapon