From owner-freebsd-hackers@FreeBSD.ORG  Thu Mar 11 11:12:13 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0066B106566B;
	Thu, 11 Mar 2010 11:12:13 +0000 (UTC)
	(envelope-from a_best01@uni-muenster.de)
Received: from zivm-relay1.uni-muenster.de (ZIVM-RELAY1.UNI-MUENSTER.DE
	[128.176.192.12])
	by mx1.freebsd.org (Postfix) with ESMTP id 5C0788FC08;
	Thu, 11 Mar 2010 11:12:11 +0000 (UTC)
X-IronPort-AV: E=Sophos;i="4.49,619,1262559600"; d="scan'208";a="298833591"
Received: from zivmaildisp1.uni-muenster.de (HELO
	ZIVMAILUSER01.UNI-MUENSTER.DE) ([128.176.188.85])
	by zivm-relay1.uni-muenster.de with ESMTP; 11 Mar 2010 12:12:10 +0100
Received: by ZIVMAILUSER01.UNI-MUENSTER.DE (Postfix, from userid 149459)
	id 364F71B0768; Thu, 11 Mar 2010 12:12:10 +0100 (CET)
Date: Thu, 11 Mar 2010 12:12:09 +0100 (CET)
From: Alexander Best <alexbestms@wwu.de>
Sender: <a_best01@uni-muenster.de>
Organization: Westfaelische Wilhelms-Universitaet Muenster
To: Jaakko Heinonen <jh@FreeBSD.org>
Message-ID: <permail-20100311111209f0889e8400002de2-a_best01@message-id.uni-muenster.de>
In-Reply-To: <20100311102911.GA2574@a91-153-117-195.elisa-laajakaista.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: freebsd-hackers@FreeBSD.org, Poul-Henning Kamp <phk@phk.freebsd.dk>,
	Bruce Evans <brde@optusnet.com.au>
Subject: Re: namei() returns EISDIR for "/" (Re: svn commit: r203990 -
 head/lib/libc/sys)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Mar 2010 11:12:13 -0000

Jaakko Heinonen schrieb am 2010-03-11:
> On 2010-03-10, Alexander Best wrote:
> > could this panic have been triggered by the patch?

> It doesn't look like it's caused by the patch.

> > panic() at panic+0x15f
> > _mtx_lock_flags() at _mtx_lock_flags+0xc5
> > fdesc_allocvp() at fdesc_allocvp+0xbf
> > fdesc_lookup() at fdesc_lookup+0x15c

> > this was 100% reducible when doing `portsnap fetch` though i
> > changed a lot of
> > stuff in my kernel config and reverted a lot of src patches to
> > resolve the
> > issue so i'm not sure what exactly was causing it.

> The panic happened in fdescfs code. Did you have local patches
> related
> to fdescfs?

after reverting a few patches (including yours) i got rid of the problem. i
then re-applied your patch and noticed that (as you said) it wasn't causing
the panic.

i don't have any fdescfs specific patches in my src. i suspect however [1]
being responsible for the panic. after backing it out i got no more panics in
connection with `portsnap fetch`.

[1] http://www.mail-archive.com/freebsd-hackers@freebsd.org/msg70400.html

thanks for the help

oh...and btw.:

i'm not sure but i think i've asked this question once before in this thread:

in sys/kern/vfs_syscalls.c:kern_rmdirat() there's still local code to check
for "." and "/" after applying your patch. isn't this all being done by
calling namei() now?

cheers.
alex