From owner-cvs-all@FreeBSD.ORG Fri Apr 9 10:25:14 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D63216A4CE for ; Fri, 9 Apr 2004 10:25:14 -0700 (PDT) Received: from root.org (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 2986743D55 for ; Fri, 9 Apr 2004 10:25:14 -0700 (PDT) (envelope-from nate@root.org) Received: (qmail 48783 invoked by uid 1000); 9 Apr 2004 17:25:14 -0000 Date: Fri, 9 Apr 2004 10:25:14 -0700 (PDT) From: Nate Lawson To: Mark Murray In-Reply-To: <20040409150158.99C0416A545@hub.freebsd.org> Message-ID: <20040409102152.I48723@root.org> References: <20040409150158.99C0416A545@hub.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 identcpu.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Apr 2004 17:25:14 -0000 On Fri, 9 Apr 2004, Mark Murray wrote: > markm 2004/04/09 08:01:44 PDT > > FreeBSD src repository > > Modified files: > sys/i386/i386 identcpu.c > Log: > Add extra output to show when VIA C3 Nehemiah CPUs have hardware > Random Number Generator (RNG) and/or Advanced Cryptography Engine > (ACE). > > Revision Changes Path > 1.136 +11 -1 src/sys/i386/i386/identcpu.c If you're going to add support for either, please don't do it as OpenBSD did with spamming identcpu.c with a hardware driver. We've already extracted longrun support from identcpu.c and going the other way would be a huge error. Also, I'd like to review any code if you plan to commit some. Thanks, -Nate