From owner-freebsd-hackers@FreeBSD.ORG Thu Oct 21 18:02:31 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 831781065695; Thu, 21 Oct 2010 18:02:31 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id E79D08FC16; Thu, 21 Oct 2010 18:02:30 +0000 (UTC) Received: by wyb38 with SMTP id 38so5464984wyb.13 for ; Thu, 21 Oct 2010 11:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; bh=zD3PhXSZn0pJMrYYq2XAHJH10bRF6b+M2ki3dynj064=; b=HLixPEesTRBsvOHSpZpkGHXqv5j1rVUQabXm0jdLLUsA6xWi2EEP63S+EbAQ5j+vT6 O8eqsp/Kh5u8IcqlEuDUqcx6bJRKckbnTMxUcTFRj6LjhMCgmP0NMM3Dq56DczrPcomP hknKRDhs/gLjaldsxXzNX3tZKMB8OCZ+BjoKY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=qaZWbY5BSTw1rPNyG9RFwh86MdEC9O+Q6GbAq7lq0NyE8lYGBAwJQi2XplMy1iFbE2 vAfMPIYhUCIEawZ5cf4ZNLrIHu0PjFNAAyGYMms6o7YOSFa2FNqt9nu4h54pAiMMnvzg Db0Ij5tdsT+gfbWDMplnEBOojlefXBrsTM78g= MIME-Version: 1.0 Received: by 10.216.13.17 with SMTP id a17mr10017999wea.46.1287684149769; Thu, 21 Oct 2010 11:02:29 -0700 (PDT) Sender: yanegomi@gmail.com Received: by 10.216.135.67 with HTTP; Thu, 21 Oct 2010 11:02:29 -0700 (PDT) In-Reply-To: <20101021174658.GA11107@freebsd.org> References: <20101021174658.GA11107@freebsd.org> Date: Thu, 21 Oct 2010 11:02:29 -0700 X-Google-Sender-Auth: y7yqHl3Y2jqT6jywnz_VUmc6g30 Message-ID: From: Garrett Cooper To: Alexander Best Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-hackers@freebsd.org Subject: Re: a few minor kldstat fixes X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2010 18:02:31 -0000 On Thu, Oct 21, 2010 at 10:46 AM, Alexander Best wrote: > this patch fixes the following issues: > > - unbreak 'kldstat -i 999 -v' output > - remove an unnecessary set of "{" and "}" > - change printfile() to blend into the overall style used in kldstat.c > - add a kldstat(8) entry to document the relationship between the "-i" and "-n" flags Might be better to say that the -i and -n options are mutually exclusive in the manpage, and have the args parser parse out those two cases and bail if both of them are set. Thanks! -Garrett