Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 8 Feb 2023 00:26:16 GMT
From:      Eric Joyner <erj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 75b7e4f157e0 - stable/13 - Adjust irdma_prep_for_unregister() definition to avoid clang 15 warning
Message-ID:  <202302080026.3180QG2H096120@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by erj:

URL: https://cgit.FreeBSD.org/src/commit/?id=75b7e4f157e0ece9a028bb7c43ee9f5727a565a5

commit 75b7e4f157e0ece9a028bb7c43ee9f5727a565a5
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2022-07-24 21:27:24 +0000
Commit:     Eric Joyner <erj@FreeBSD.org>
CommitDate: 2023-02-08 00:23:49 +0000

    Adjust irdma_prep_for_unregister() definition to avoid clang 15 warning
    
    With clang 15, the following -Werror warning is produced:
    
        sys/dev/irdma/icrdma.c:621:26: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
        irdma_prep_for_unregister()
                                 ^
                                  void
    
    This is because irdma_prep_for_unregister() is declared with a (void)
    argument list, but defined with an empty argument list. Make the
    definition match the declaration.
    
    (cherry picked from commit ee6c09ac73b5eab848c66e539f8b3293a5abd7f8)
---
 sys/dev/irdma/icrdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/irdma/icrdma.c b/sys/dev/irdma/icrdma.c
index 1bc78dce90aa..c5a42eb863e6 100644
--- a/sys/dev/irdma/icrdma.c
+++ b/sys/dev/irdma/icrdma.c
@@ -618,7 +618,7 @@ irdma_remove(struct ice_rdma_peer *peer)
  * irdma_prep_for_unregister - ensure the driver is ready to unregister
  */
 static void
-irdma_prep_for_unregister()
+irdma_prep_for_unregister(void)
 {
 	struct irdma_handler *hdl;
 	unsigned long flags;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202302080026.3180QG2H096120>