From owner-cvs-src@FreeBSD.ORG Sun May 6 10:02:06 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7B59716A400; Sun, 6 May 2007 10:02:06 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 506A913C45B; Sun, 6 May 2007 10:02:06 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id DBE0B46F73; Sun, 6 May 2007 06:02:05 -0400 (EDT) Date: Sun, 6 May 2007 11:02:05 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Dag-Erling Smorgrav In-Reply-To: <200705061000.l46A0Swm062866@repoman.freebsd.org> Message-ID: <20070506110113.A24765@fledge.watson.org> References: <200705061000.l46A0Swm062866@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libgeom libgeom.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 May 2007 10:02:06 -0000 On Sun, 6 May 2007, Dag-Erling Smorgrav wrote: > des 2007-05-06 10:00:27 UTC > > FreeBSD src repository > > Modified files: > lib/libgeom libgeom.h > Log: > Remove parameter names from prototypes to avoid namespace issues. While possibly not required to fix the build, I think the 'write' argument should be renamed in the .c and .3 files also to avoid future confusion and conflicts. In my local tree I've renamed it to "dowrite", but perhaps Pawel can commit whatever he thinks makes the most sense. Robert N M Watson Computer Laboratory University of Cambridge