Date: Thu, 8 Aug 2024 07:52:42 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: "Jason E. Hale" <jhale@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6c2f347f45e4 - main - devel/abseil: update Abseil C++ to LTS version 20240722.0 Message-ID: <ZrR5SiOGl6gm0boJ@FreeBSD.org> In-Reply-To: <CAJE75NEPKw4DwdHvx2Vj-WDqZXQ7t34_tG69GbHqwAS2WOo2yQ@mail.gmail.com> References: <202408070601.47761HrZ051940@gitrepo.freebsd.org> <CAJE75NEPKw4DwdHvx2Vj-WDqZXQ7t34_tG69GbHqwAS2WOo2yQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 07, 2024 at 11:56:30PM -0400, Jason E. Hale wrote: > On Wed, Aug 7, 2024 at 2:01???AM Alexey Dokuchaev wrote: > > commit 6c2f347f45e45cd71bb0aa7fdcaa96667c5a483b > > > > devel/abseil: update Abseil C++ to LTS version 20240722.0 > > > > ... > > +USES= cmake compiler:c++17-lang pathfix > > CMAKE_ARGS= -DBUILD_SHARED_LIBS:BOOL=ON \ > > -DCMAKE_CXX_STANDARD=17 # force the same highest ... > > Is there anything preventing > CMAKE_ARGS+=-DABSL_PROPAGATE_CXX_STD:BOOL=ON from being set for > dependencies such as devel/libphonenumber? Nothing, I guess, I simply didn't know about this knob, which is a rather lame excuse because it says quite loud in the build log: CMake Warning at CMakeLists.txt:52 (message): A future Abseil release will default ABSL_PROPAGATE_CXX_STD to ON for CMake 3.8 and up. We recommend enabling this option to ensure your project still builds correctly. > It would be nice to get rid of the current workaround in that port. Sure thing, I'll add it. It would probably require to rebuild all dependent ports again to check that nothing breaks which might take time though. :( Thanks for letting me know! ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZrR5SiOGl6gm0boJ>