From owner-freebsd-arm@FreeBSD.ORG Fri May 29 01:23:07 2015 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F0C27EF0 for ; Fri, 29 May 2015 01:23:07 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C0BBD1704 for ; Fri, 29 May 2015 01:23:07 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by pabru16 with SMTP id ru16so36184973pab.1 for ; Thu, 28 May 2015 18:23:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=O1lK6vfJGYDObaqLElOs4mHwVMiFAGhgW31QXx+0lfA=; b=ONc9qxV98w5WaTpVqTQcPCeDnkvAp614M3y8uCL/kbkF7iDzV/k7VtIZhlzRLLQu3q uhrEBRORgVeO4ioXDgbQEBWPPUC4BbovPoGour+2AezKhQJEvqqnfwKYnchs0UlpO99C aH49kXWX5ES5dsoJCkJ+CWGiLcgBoLobBiRxH/Lp+BkiwfzUIToPtylzIwF0CUjl2Jt8 /ac3m2/Gfw3Y0NuOeXy38LdHYyOR0JnUqinvEkD5u2t6uzAXNUFnQ5kmXfgH3wn3niiS eI3KeRjV42HsONvGAwBTCuVIto1XKOeu9jjtUy16VBGoZEW22W5aKfVgD93eXWfXozcE poSA== X-Gm-Message-State: ALoCoQlmIqqH06EWFkHxnWgIgy54uOvzvfUa+4UvRuvBL/2EHkWicRBQaj+xQT6QDGUmMgN+vyWO X-Received: by 10.66.184.133 with SMTP id eu5mr10254090pac.75.1432862586934; Thu, 28 May 2015 18:23:06 -0700 (PDT) Received: from [10.64.25.120] ([69.53.236.236]) by mx.google.com with ESMTPSA id ca2sm3651377pdb.25.2015.05.28.18.23.05 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 28 May 2015 18:23:06 -0700 (PDT) Sender: Warner Losh Subject: Re: am335x-bone.dts not exist Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Content-Type: multipart/signed; boundary="Apple-Mail=_B599E26D-3C6F-4784-BA6F-4FDF28E8919F"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Warner Losh In-Reply-To: <27DD7AA7-4B66-4A8C-A529-1D67B081326E@kientzle.com> Date: Thu, 28 May 2015 19:23:03 -0600 Cc: FreeBSD current , freebsd-arm , Garrett Cooper Message-Id: References: <8FF14032-CAAA-41AD-A3A7-DBBAA69D2153@bluezbox.com> <4F170567-59B8-477B-8524-D15AF58288C2@kientzle.com> <142808D5-D628-4FCF-BDF4-BBC96D91E118@bsdimp.com> <27DD7AA7-4B66-4A8C-A529-1D67B081326E@kientzle.com> To: Tim Kientzle X-Mailer: Apple Mail (2.2098) X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2015 01:23:08 -0000 --Apple-Mail=_B599E26D-3C6F-4784-BA6F-4FDF28E8919F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 > On May 25, 2015, at 4:19 PM, Tim Kientzle wrote: >=20 >>=20 >> On May 25, 2015, at 8:25 AM, Warner Losh wrote: >>=20 >>>=20 >>> On May 24, 2015, at 7:44 PM, Tim Kientzle wrote: >>>=20 >>>>=20 >>>> On May 24, 2015, at 12:55 AM, Oleksandr Tymoshenko = wrote: >>>>=20 >>>>=20 >>>>> On May 24, 2015, at 12:12 AM, Garrett Cooper = wrote: >>>>>=20 >>>>> On May 24, 2015, at 0:07, Oleksandr Tymoshenko = wrote: >>>>>=20 >>>>>>> On May 23, 2015, at 7:21 PM, Andrey Fesenko = wrote: >>>>>>>=20 >>>>>>> # uname -a >>>>>>> FreeBSD des.local 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r283306: = Sat >>>>>>> May 23 11:56:46 MSK 2015 >>>>>>> root@des.local:/usr/obj/usr/src/sys/GENERIC amd64 >>>>>>>=20 >>>>>>> I'm build BEAGLEBONE with crochet. >>>>>>>=20 >>>>>>> build error >>>>>>>=20 >>>>>>> Mounting UFS partition 1 at /usr/obj/_.mount.freebsd >>>>>>> Installing U-Boot from : = /usr/local/share/u-boot/u-boot-beaglebone >>>>>>> Error: beaglebone.dts:29.1-2 syntax error >>>>>>> FATAL ERROR: Unable to parse input tree >>>>>>>=20 >>>>>>>=20 >>>>>>> file /usr/src/sys/boot/fdt/dts/arm/beaglebone.dts contain = #include >>>>>>> "am335x-bone.dts" but this file not existence. Need use = am335x-evm.dts >>>>>>> or else? >>>>>>=20 >>>>>>=20 >>>>>> am335x-bone.dts in in sys/gnu/dts/arm/, it's a file provided by = vendor (TI) >>>>>>=20 >>>>>> I guess crochet does not have this path as include path when = compiling >>>>>> dts files. >>>>>=20 >>>>> Pardon me for being a bit daft potentially, but shouldn=92t = #include work for all dts files (look for #include in this doc: = http://events.linuxfoundation.org/sites/events/files/slides/petazzoni-devi= ce-tree-dummies.pdf )? >>>>> Thanks! >>>>>=20 >>>>=20 >>>>=20 >>>> #include in dts file is handled by cpp(1). /include/ is handled >>>> by dtc I believe >>>>=20 >>>> You can take a look at how FreeBSD compiles dts files in >>>> sys/tools/fdt/make_dtb.sh >>>>=20 >>>> crochet does not have cpp stage of compilation and before my TI >>>> code/devicetree refactoring none of the dts files referenced in >>>> crochet used #include. That's why problem never appeared. >>>>=20 >>>> Fix is just a matter of fixing freebsd_install_fdt in = lib/freebsd.sh. >>>> If nobody beats me to it I'll try to fix it and submit pull request = to Tim. >>>=20 >>> I=92m testing a fix for this now. >>>=20 >>> Thanks for providing such detailed information. >>=20 >> Is there any reason the standard dts to dtb script isn=92t being used = instead of enshrining another copy of that outside the tree which may = break if/when we need to enhance the current script? >=20 > Until recently, this didn=92t seem necessary; it was a lot simpler to = just invoke dtc. I changed things to require cpp when I started merging in the upstream = dts files that required it. This was almost a year ago now, about the time we = switched back to the GPL dtc because the BSDL one choked on a lot of the newer = files. > But times change: https://github.com/freebsd/crochet/commit/22d7555 Cool! Thanks! Warner --Apple-Mail=_B599E26D-3C6F-4784-BA6F-4FDF28E8919F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVZ793AAoJEGwc0Sh9sBEAEWsQAIQApFaKyBqnD2/cNm0DmzG+ UgOxDtHWFD6t8aE2aEdI1eThb2f+VoR4rFh6A0trKDHdUTa0PX6HRwc95OQf+pUW g3oXjY5vbg2xgeLvTFBBbP1lMeXI6Oq7LlbAMDAYI7aI7XWIIFWLCaRl/lSosWav Z/WXkUJg78WdGt7eoTxhUiC/AGXyGrhy6kCHV7BMMXo5TSN7uukMWzyWmPou1Y9t JwWJPD6I/yibsAuJoXnDn74w7quq7qexW2K1cw/atCkkK+lIeF9fqOrzbCxEyUo1 vmluEhHXBTn8TgNN9iuSET7d23UlXo+w/1HEU2faRz1sQhYfS++Ka687/67vQNbA 5rk2HRxeLi7ya+ySUmK4EzJJRVS3lGLu5yahSJRh0x2O99zemOL92q15+2IguujM zoZg9+Lc7nuUx93hNruAqWzoOepDb5J/KZs8hc+akzpdd1Pd76zZ8xyYToBle9bl KvQOtiWw2/PGEywJeIxxknBwUw+UILWTIGUjpfNo/e3+x/fnXYxNwm028igDjAkc uvR+M72tp9zpoo8dpDo718sz9U2LEE3KvBUx5pPbjiqQpp6KbG90CVuEDA/B3Z4f r7uYemPEdfjUCcB4uwK4WyCiVRqXTcFGTLyUvhJs4GItcYEoLYUH18xLh2+k/3W5 zdednss+nO4fD55cpZed =Un28 -----END PGP SIGNATURE----- --Apple-Mail=_B599E26D-3C6F-4784-BA6F-4FDF28E8919F--