From owner-freebsd-scsi@FreeBSD.ORG  Wed Jul 14 10:09:55 2010
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: scsi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2CE02106567A
	for <scsi@freebsd.org>; Wed, 14 Jul 2010 10:09:55 +0000 (UTC)
	(envelope-from pawel.worach@gmail.com)
Received: from mail-ew0-f54.google.com (mail-ew0-f54.google.com
	[209.85.215.54])
	by mx1.freebsd.org (Postfix) with ESMTP id B34608FC08
	for <scsi@freebsd.org>; Wed, 14 Jul 2010 10:09:54 +0000 (UTC)
Received: by ewy26 with SMTP id 26so1502244ewy.13
	for <scsi@freebsd.org>; Wed, 14 Jul 2010 03:09:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:from:content-type
	:content-transfer-encoding:subject:date:message-id:to:mime-version
	:x-mailer; bh=a8sxolhdpK/dFn+i5f0pzBJLNrvuV/rf2KXwElUWMyA=;
	b=Ot3np4oaqolrtddhPjyES5oO5GaYuw38cIeJ4Ehgs+ap9YYlfEpcWtgwwT63k0R1Ac
	CBwFlYL1i4WqmSfDpT6oE3opNs1Piz+1NfUIyAxexbQkDiWpO5Lasa0fJHxvtVMfR9+/
	UCkl7JwhYzf8uyQ8N+4VrSwu03PBBoAEtGgnk=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=from:content-type:content-transfer-encoding:subject:date:message-id
	:to:mime-version:x-mailer;
	b=RwoP2ObTUOY96Uv2wL0CS+WpjQDKgSH/nqVuTu2+3XQGQ7+dfm9gUMVqB5fe67mfgy
	+S3dadErgWPzwyYQFI1q+aivebcdjjF+GPlXP7rHL64ezGuKiy8UQ+fj0a8HwTywJvaT
	NwsVwwg5yT0TfWjI3Zc6Yc+tSiuuOGsmcisZc=
Received: by 10.213.19.205 with SMTP id c13mr4002483ebb.99.1279100700202;
	Wed, 14 Jul 2010 02:45:00 -0700 (PDT)
Received: from [172.16.0.199] (c80-216-186-179.bredband.comhem.se
	[80.216.186.179])
	by mx.google.com with ESMTPS id v59sm55677925eeh.10.2010.07.14.02.44.59
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Wed, 14 Jul 2010 02:44:59 -0700 (PDT)
From: Pawel Worach <pawel.worach@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Date: Wed, 14 Jul 2010 11:44:57 +0200
Message-Id: <51186C1C-E61D-4A9D-8A78-749F48E89CE0@gmail.com>
To: scsi@freebsd.org
Mime-Version: 1.0 (Apple Message framework v1081)
X-Mailer: Apple Mail (2.1081)
Cc: 
Subject: [patch] fix aicasm build with clang.
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Jul 2010 10:09:55 -0000

Hi,

llvm/clang as of r108260 doesn't like aicasm_gram.[c,y]

sys/dev/aic7xxx/aicasm/aicasm_gram.y:1826:51: error: use of logical || =
with constant operand; switch to bitwise | or remove constant =
[-Wlogical-bitwise-confusion]
        if (opcode =3D=3D AIC_OP_AND || opcode =3D=3D AIC_OP_JNZ || =
AIC_OP_JZ)
                                                         ^  ~~~~~~~~~

Bug ?

Index: sys/dev/aic7xxx/aicasm/aicasm_gram.y
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/dev/aic7xxx/aicasm/aicasm_gram.y	(revision 210025)
+++ sys/dev/aic7xxx/aicasm/aicasm_gram.y	(working copy)
@@ -1823,7 +1823,7 @@
 	int and_op;
=20
 	and_op =3D FALSE;
-	if (opcode =3D=3D AIC_OP_AND || opcode =3D=3D AIC_OP_JNZ || =
AIC_OP_JZ)
+	if (opcode =3D=3D AIC_OP_AND || opcode =3D=3D AIC_OP_JNZ || =
opcode =3D=3D AIC_OP_JZ)
 		and_op =3D TRUE;
=20
 	/*

--=20
Pawel