From owner-svn-src-projects@FreeBSD.ORG Mon Sep 17 15:14:07 2012 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 075B710656FA; Mon, 17 Sep 2012 15:14:07 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id CB8E88FC18; Mon, 17 Sep 2012 15:14:06 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 25735B9BC; Mon, 17 Sep 2012 11:14:06 -0400 (EDT) From: John Baldwin To: Andre Oppermann Date: Mon, 17 Sep 2012 11:13:06 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p17; KDE/4.5.5; amd64; ; ) References: <201207301350.q6UDobCI099069@svn.freebsd.org> <5056D078.3020904@freebsd.org> In-Reply-To: <5056D078.3020904@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201209171113.06861.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 17 Sep 2012 11:14:06 -0400 (EDT) Cc: Davide Italiano , mlaier@freebsd.org, svn-src-projects@freebsd.org, attilio@freebsd.org, Konstantin Belousov , src-committers@freebsd.org, Stephan Uphoff Subject: Re: svn commit: r238907 - projects/calloutng/sys/kern X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2012 15:14:07 -0000 On Monday, September 17, 2012 3:25:44 am Andre Oppermann wrote: > Hello Attilio, > > could you integrate and test this patch from Isilon as well: > > Add INVARIANT and WITNESS support to rm_lock locks and optimize the > synchronization path by replacing a LIST of active readers with a > TAILQ. > > Obtained from: Isilon > Submitted by: mlaier > > http://svn.freebsd.org/changeset/base/234648 > > You're far deeper into locking than I am. Some of this is already in the tree, and their WITNESS changes don't quite work correctly. I have several fixes (including some of these already) that I am just waiting to develop a good test for. Having an _rm_assert() to pull from will be good though. -- John Baldwin