From owner-freebsd-ports-bugs@freebsd.org Sat Apr 24 10:27:10 2021 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 632B35FA287 for ; Sat, 24 Apr 2021 10:27:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4FS6ly2B8pz4mG9 for ; Sat, 24 Apr 2021 10:27:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 4AEE95FA09E; Sat, 24 Apr 2021 10:27:10 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4AB315FA192 for ; Sat, 24 Apr 2021 10:27:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FS6ly1bfRz4mQF for ; Sat, 24 Apr 2021 10:27:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1F59C1EDE0 for ; Sat, 24 Apr 2021 10:27:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 13OARAIf093749 for ; Sat, 24 Apr 2021 10:27:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 13OARATM093748 for ports-bugs@FreeBSD.org; Sat, 24 Apr 2021 10:27:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 253750] sysutils/cpdup description is inaccurate Date: Sat, 24 Apr 2021 10:27:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: gmarco@giovannelli.it X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Apr 2021 10:27:10 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253750 --- Comment #6 from Gianmarco Giovannelli --- I think the correct pkg-descr should be something like: "This is the distribution of "cpdup", a powerful filesystem mirroring and backup utility which also has file integrity testing features, supports incremental backups, and remote mirroring via ssh. Note: This port does not copy (or mirror) any FreeBSD supported ACL types a= nd Extended Attributes" I have written also to Matt Dillon (the original author) asking to him about this and him replied to me: "I didn't add support for ACLs but cpdup uses a fairly robust extension mechanism to the protocol. You can definitely add the feature if you would like. ACLs are something we never threw into dragonfly so I didn't code it up at = the time. In anycase, if you would like to add support it shouldn't be too hard. You would want to bump the protocol version and then implement the front-end and back-end messages to read and set the ACLs. e.g. in hcproto.c there are various frontend functions like hc_stat() and backend functions like rc_sta= t(). There is also the dispatch table for the backend near the top. You would = use a protocol version test to check for remote support of the new messages and= you would also want to handle error responses when the remote end supports the = new messages but the target filesystem does not have ACLs. The maximum message size is 65536 bytes, so if encoding all the ACLs in one message would exceed that you would have to break it up into multiple messages. If the ACLs affect the destination end's ability to make adjustments to the file, you may have to be careful about how you order the messages. Also conditionalize compilation if the OS doesn't have the system calls, e.= g. #ifdef on something like ACL_MAX_ENTRIES, and conditionalize support for various tags and types and such. If you (or anyone) want to do this work, I would be happy to incorporate it into the master copy of cpdup. It would be nice if it supported ACLs. -Matt" So if someone wants to provide some patches we can test and try to implement them ... and then send to Matt. If not the pkg-descr I have sent is enough correct. Is it ok ?! Thanks. --=20 You are receiving this mail because: You are the assignee for the bug.=