Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 24 Apr 2021 10:27:10 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 253750] sysutils/cpdup description is inaccurate
Message-ID:  <bug-253750-7788-lunth38p9b@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-253750-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-253750-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253750

--- Comment #6 from Gianmarco Giovannelli <gmarco@giovannelli.it> ---
I think the correct pkg-descr should be something like:



"This is the distribution of "cpdup", a powerful filesystem mirroring and
backup utility which also has file integrity testing features, supports
incremental backups, and remote mirroring via ssh.

Note: This port does not copy (or mirror) any FreeBSD supported ACL types a=
nd
Extended Attributes"



I have written also to Matt Dillon (the original author) asking to him about
this and him replied to me:


"I didn't add support for ACLs but cpdup uses a fairly robust extension
mechanism to the protocol.
You can definitely add the feature if you would like.
ACLs are something we never threw into dragonfly so I didn't code it up at =
the
time.

In anycase, if you would like to add support it shouldn't be too hard.  You
would want to bump the protocol version and then implement the front-end and
back-end messages to read and set the ACLs.   e.g. in hcproto.c there are
various frontend functions like hc_stat() and backend functions like rc_sta=
t().
 There is also the dispatch table for the backend near the top.  You would =
use
a protocol version test to check for remote support of the new messages and=
 you
would also want to handle error responses when the remote end supports the =
new
messages but the target filesystem does not have ACLs.   The maximum message
size is 65536 bytes, so if encoding all the ACLs in one message would exceed
that you would have to break it up into multiple messages.

If the ACLs affect the destination end's ability to make adjustments to the
file, you may have to be careful about how you order the messages.

Also conditionalize compilation if the OS doesn't have the system calls, e.=
g.
#ifdef on something like ACL_MAX_ENTRIES, and conditionalize support for
various tags and types and such.

If you (or anyone) want to do this work, I would be happy to incorporate it
into the master copy of cpdup.  It would be nice if it supported ACLs.

-Matt"



So if someone wants to provide some patches we can test and try to implement
them ... and then send to Matt.
If not the pkg-descr I have sent is enough correct.

Is it ok ?!


Thanks.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-253750-7788-lunth38p9b>