From owner-svn-ports-all@freebsd.org  Fri Dec 29 07:48:04 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3C33EAFEF7;
 Fri, 29 Dec 2017 07:48:04 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 844C9805D4;
 Fri, 29 Dec 2017 07:48:04 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id CA06B1613A; Fri, 29 Dec 2017 07:48:03 +0000 (UTC)
Date: Fri, 29 Dec 2017 07:48:03 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Wen Heping <wen@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r457491 - in head/textproc/sxml: . files
Message-ID: <20171229074803.GA14519@FreeBSD.org>
References: <201712290330.vBT3UDDY076733@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201712290330.vBT3UDDY076733@repo.freebsd.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Dec 2017 07:48:04 -0000

On Fri, Dec 29, 2017 at 03:30:13AM +0000, Wen Heping wrote:
> New Revision: 457491
> URL: https://svnweb.freebsd.org/changeset/ports/457491
> 
> Log:
>   - Update to 1.0.7
>   - Update LICENSE
> 
> Modified: head/textproc/sxml/Makefile
> ...
> @@ -2,23 +2,21 @@
>  
> -USES=		tar:bzip2
>  GNU_CONFIGURE=	yes
>  USE_LDCONFIG=	yes
> +USES=		tar:bzip2

This change (USES move) is both gratuitous and wrong.

> -MAKE_JOBS_UNSAFE=	yes

So it builds fine with -jX now?  What was the reason for failures before?
Commit message tells nothing about this and how was it fixed (if it was).

> +do-test:	build
> +	cd ${BUILD_WRKSRC}/examples && ${MAKE} all

${MAKE_CMD}, not ${MAKE}.  Also, consider using -C instead of `cd'.  On
a related note, I don't exactly see how building of examples performs
any sort of tests; it looks like nothing is being run or checked.

> Modified: head/textproc/sxml/pkg-descr
> ...
> @@ -1,4 +1,5 @@
> -SXML is a skimpy XML parsing and grafting C library that you can use
> -to read and write XML-like configuration file for your application.
> +SXML is a skimpy XML parsing and grafting C library that you can use to read
> +and write XML-like configuration file for your application.
>  
> +Author:	Kouichi ABE (WALL) <kouichi@MysticWALL.COM>

This line was added wrongly; few years ago ports were sweeped to remove
direct author attribution, and now you're adding them back.  Please don't.

./danfe