Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 26 Sep 2019 08:01:00 +0000
From:      bugzilla-noreply@freebsd.org
To:        xfce@FreeBSD.org
Subject:   [Bug 240804] x11/xfce4-screensaver: Newly Installed via pkg upgrade Does Not Allow Password Input and xscreensaver No Longer Function Forcing User to Reboot Frequently and/or Data Loss
Message-ID:  <bug-240804-28711-wTIKmurOvn@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-240804-28711@https.bugs.freebsd.org/bugzilla/>
References:  <bug-240804-28711@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240804

--- Comment #12 from Guido Falsi <madpilot@FreeBSD.org> ---
(In reply to John from comment #10)

Please don't rush things.

You created 3 bug reports for the same issue, one referencing a port which =
is
only marginally related to the issue (xscreensaver), since it's not install=
ing
any file causing it. This is strictly an XFCE problem.

Please let's keep the conversation in one place only. This is one bug. with=
 two
strictly related problems.

- xfce installs two .desktop files (one via xfce4-session port and one via =
the
xfce4-screensaver port) which launch screensaver applications and, if both =
are
installed, both are lunched simultaneously. This setup cannot work

- to make things worse, the GUI to choose which one is enabled ends up with=
 the
same description for both of them.

I already filed a bug report upstream with xfce4-screensaver [1] asking to
change the name in the desktop file. That's enough. I think that your chang=
es
are too invasive and would not be accepted upstream. Also you patch is touc=
hing
the wrong file. Anyway if you want to push to upstream for your changes, I'd
suggest you followup to my bug report there with a correct patch relative to
their sources.

My plan is to change the description with a little brutal (in relation to t=
he
translations [2]) patch to the xfce4-screensaver .desktop file, so as to get
different descriptions, and make xfce4-session install the xscreensaver
.desktop file disabled, and add a note in UPDATING.

This logic is due to the fact that the xfce metaport installs xfce4-screens=
aver
by default, so having the default xscreensaver.desktop file enabled by defa=
ult
would cause the issue to appear for everybody.

I need some time to test all this and I'll also be away for a few days, so I
don't think I'll be able to commit a fix before monday.

The other option is to revert the xfce metaport to depending on xscreensave=
r as
before and let people manually install xfce4-screensaver if they want to. B=
ut
since xfce now has it's own screensaver component this does not look optima=
l.

Somewhere in your messages you ask me not to disable xscreensaver by
default...why? Having BOTH enabled cannot work.


[1] https://bugzilla.xfce.org/show_bug.cgi?id=3D15991, referenced in bug #2=
40811

[2] we can't only patch the English version and wait for xfce to translate =
it,
this would require a lot of time, and in the while translated versions would
get the same text anyway. Also any proposed name/description change we send=
 to
xfce for inclusion needs to be accepted there, which we can't force

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-240804-28711-wTIKmurOvn>