From owner-cvs-all Mon Aug 9 17:29: 7 1999 Delivered-To: cvs-all@freebsd.org Received: from allegro.lemis.com (allegro.lemis.com [192.109.197.134]) by hub.freebsd.org (Postfix) with ESMTP id A1D8214D75; Mon, 9 Aug 1999 17:27:05 -0700 (PDT) (envelope-from grog@freebie.lemis.com) Received: from freebie.lemis.com (freebie.lemis.com [192.109.197.137]) by allegro.lemis.com (8.9.1/8.9.0) with ESMTP id JAA03814; Tue, 10 Aug 1999 09:51:59 +0930 (CST) Received: (from grog@localhost) by freebie.lemis.com (8.9.3/8.9.0) id JAA41579; Tue, 10 Aug 1999 09:51:56 +0930 (CST) Date: Tue, 10 Aug 1999 09:51:56 +0930 From: Greg Lehey To: Peter Wemm Cc: Dag-Erling Smorgrav , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/vinum vinum.c Message-ID: <19990810095156.P31076@freebie.lemis.com> References: <19990809213915.J31076@freebie.lemis.com> <19990809124044.46D2D1C1E@overcee.netplex.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.4i In-Reply-To: <19990809124044.46D2D1C1E@overcee.netplex.com.au>; from Peter Wemm on Mon, Aug 09, 1999 at 08:40:44PM +0800 WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-41-739-7062 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Monday, 9 August 1999 at 20:40:44 +0800, Peter Wemm wrote: > Greg Lehey wrote: >> On Monday, 9 August 1999 at 13:34:29 +0200, Dag-Erling Smorgrav wrote: >>> Greg Lehey writes: >>>> Log: >>>> vinumopen: add code to open raw subdisks. This is now used to >>>> initialize subdisks. Probably the plex-related subdisk type will die >>>> a death. >>> ^ >>> I get the feeling you forgot an adjective :) >> >> You get an incorrect feeling. >> >> Greg > > Speaking of which, I've started getting this: That means it's repeatable? > db> trace > read_drive(c0882000,c0885000,20000,1200,0) at read_drive+0xa8 > vinum_scandisk(c0287fc4,4,0,c0288f2c,c617ed8c) at vinum_scandisk+0x31a > parse_config(c087bc00,c026f108,0,0,c617edac) at parse_config+0x65 > parse_user_config(c087bc00,c026f108,c617ee08,c0288f2c,c5cb7620) at parse_user_config+0x17 > vinumioctl(c0288f2c,c4004640,c087bc00,3,c5cb7620) at vinumioctl+0x2b8 > spec_ioctl(c617ee08,c617edec,c01f8f1d,c617ee08,c617ee98) at spec_ioctl+0x3c > spec_vnoperate(c617ee08,c617ee98,c01894e9,c617ee08,0) at spec_vnoperate+0x15 > ufs_vnoperatespec(c617ee08,0,c086dd80,400,fde000) at ufs_vnoperatespec+0x15 > vn_ioctl(c086dd80,c4004640,c087bc00,c5cb7620,c5cb7620) at vn_ioctl+0xdd > ioctl(c5cb7620,c617ef80,4,bfbfc90c,4) at ioctl+0x1ef > syscall(2f,2f,2f,4,bfbfc90c) at syscall+0x186 > Xint0x80_syscall() at Xint0x80_syscall+0x31 > > Specifically, vinumio.c line 341: > > /* XXX Check this. I think the test is wrong */ > if (drive->vp->v_lastr + bscale == blocknum) { > > drive->vp is NULL at this point. I didn't get a chance to look further, my > beloved 4 year old pressed the reset button at about that point. Strange. It would really help if you could get a dump and look at the The comment refers to the arithmetic comparison, not the possibility of a panic :-) At this point, the drive should be up, but that shouldn't be possible without an initialized vp. Can you dump the configuration of /dev/da0s1e (see vinum(4) for details)? Greg -- See complete headers for address, home page and phone numbers finger grog@lemis.com for PGP public key To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message