From owner-p4-projects Thu Oct 24 11:13: 5 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 6D0D137B407; Thu, 24 Oct 2002 11:13:00 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 29C2E37B4F6 for ; Thu, 24 Oct 2002 11:12:59 -0700 (PDT) Received: from mail.speakeasy.net (mail17.speakeasy.net [216.254.0.217]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1204643E8A for ; Thu, 24 Oct 2002 11:12:57 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 9138 invoked from network); 24 Oct 2002 18:13:01 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail17.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 24 Oct 2002 18:13:01 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id g9OICrn5071696; Thu, 24 Oct 2002 14:12:54 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Thu, 24 Oct 2002 14:12:57 -0400 (EDT) From: John Baldwin To: Nate Lawson Subject: Re: PERFORCE change 20056 for review Cc: Perforce Change Reviews Cc: Perforce Change Reviews , Robert Watson Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 24-Oct-2002 Nate Lawson wrote: > On Thu, 24 Oct 2002, Robert Watson wrote: >> http://perforce.freebsd.org/chv.cgi?CH=20056 >> >> Change 20056 by rwatson@rwatson_tislabs on 2002/10/24 10:53:26 >> >> During the root mount, it's possible for a NULL mountpoint >> to be passed to getnewvnode() to support the device vnode >> we're mounting on. For now, just skip setting the >> label on these vnodes, and generate a printf to make sure >> our understanding of this scenario is correct. In the >> future, we might want to add a KASSERT that the type of >> the vnode is "none", or special case the handling here >> a bit further. > > I hope you don't mean strcmp(vp->v_tag, "none") and instead mean > vp->v_type & VNON. Speaking of v_tag, can you fix the devel/libgtop port on current? This is the patch I used to get it building the other day: > cat patch-sysdeps_freebsd_procmap.c --- sysdeps/freebsd/procmap.c.orig Tue Oct 15 20:00:35 2002 +++ sysdeps/freebsd/procmap.c Tue Oct 15 20:05:54 2002 @@ -251,6 +251,7 @@ &vnode, sizeof (vnode)) != sizeof (vnode)) glibtop_error_io_r (server, "kvm_read (vnode)"); +#if __FreeBSD_version < 500000 if ((vnode.v_type != VREG) || (vnode.v_tag != VT_UFS) || !vnode.v_data) continue; @@ -261,6 +262,7 @@ maps [i-1].inode = inode.i_number; maps [i-1].device = inode.i_dev; +#endif #endif } while (entry.next != first); -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message