From owner-freebsd-i18n@FreeBSD.ORG Fri Sep 26 03:31:04 2003 Return-Path: Delivered-To: freebsd-i18n@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E7EB916A4B3; Fri, 26 Sep 2003 03:31:04 -0700 (PDT) Received: from relay.butya.kz (butya-gw.butya.kz [212.19.129.142]) by mx1.FreeBSD.org (Postfix) with ESMTP id D9C2F43FDF; Fri, 26 Sep 2003 03:31:01 -0700 (PDT) (envelope-from bp@butya.kz) Received: by relay.butya.kz (Postfix, from userid 1000) id 42C095935; Fri, 26 Sep 2003 17:30:56 +0700 (ALMST) Date: Fri, 26 Sep 2003 17:30:55 +0700 From: Boris Popov To: "R. Imura" Message-ID: <20030926103055.GD48438@vertex.kz> References: <20030922170903.GA43754@ryu16.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030922170903.GA43754@ryu16.org> User-Agent: Mutt/1.4.1i cc: freebsd-fs@freebsd.org cc: sobomax@freebsd.org cc: freebsd-i18n@freebsd.org Subject: Re: [Patch] cd9660/msdosfs/ntfs/libiconv mutli-byte extention X-BeenThere: freebsd-i18n@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Internationalization Effort List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Sep 2003 10:31:05 -0000 On Tue, Sep 23, 2003 at 02:09:03AM +0900, R. Imura wrote: > > I made a patch for multi-byte character extension > of three file systems with enhanced LIBICONV in the > kernel. File systems are cd9660(joliet part), msdosfs, > and ntfs. Great work, I should say! The patch itself looks good. There is only one minor note: function iconv_vfs_refcount() looks like misplaced one. It doesn't really belong to the iconv module and pollutes it with mount.h. May be getting this function into one of vfs_*.c files would be a better idea, although I'm don't have strong opinion on that. > > New Kernel Options (Kernel Modules) > - CD9660_ICONV (cd9660_iconv.ko) > - MSDOSFS_ICONV (msdosfs_iconv.ko) > - NTFS_ICONV (ntfs_iconv.ko) *_iconv.ko modules aren't strictly necessary and at some point they could be integrated into corresponding fs modules. libiconv.ko module isn't that large to significantly bloat install floppies. > > Any comments? And is it possible to apply this > patch to upcoming FreeBSD-5.2? I think yes. In addition, it is a good candidate for MFC into RELENG_4. > > P.S. > Though it may be very small thing, No this is great thing, thanks for your work! -- Boris Popov http://rbp.euro.ru