From owner-freebsd-wireless@FreeBSD.ORG  Wed Aug 24 14:04:56 2011
Return-Path: <owner-freebsd-wireless@FreeBSD.ORG>
Delivered-To: freebsd-wireless@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 29FD2106566B;
	Wed, 24 Aug 2011 14:04:56 +0000 (UTC)
	(envelope-from paradyse@gmail.com)
Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com
	[209.85.220.182])
	by mx1.freebsd.org (Postfix) with ESMTP id BD9D28FC19;
	Wed, 24 Aug 2011 14:04:55 +0000 (UTC)
Received: by vxh11 with SMTP id 11so1346545vxh.13
	for <multiple recipients>; Wed, 24 Aug 2011 07:04:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:from:date
	:x-google-sender-auth:message-id:subject:to:cc:content-type;
	bh=p3LNvuEKThPrK6KnFgfkrGzLFI8MxNbg6Ashl5qn2zI=;
	b=f5kEfbxBcJD8PwMeApkdxp1UMoWJh/YTkMuUPQv/xBTX27LU61l+gwZC++yRZrIrpM
	J/0JPyvIjNcI3bkhg0bGpQlQhvfctZXaj17NaLHKHJCTFCK63ZVdILRtBVVj6I51br77
	Ta05tERBOQh5AJbspdhR9A/Ejb4sDPCdSYqrY=
Received: by 10.52.70.82 with SMTP id k18mr5033216vdu.335.1314194695152; Wed,
	24 Aug 2011 07:04:55 -0700 (PDT)
MIME-Version: 1.0
Sender: paradyse@gmail.com
Received: by 10.52.167.233 with HTTP; Wed, 24 Aug 2011 07:04:35 -0700 (PDT)
In-Reply-To: <CAJ-VmoksXS+q5kcL09mF-zVJ9msUENZdb_j1+Lj_Y5c7AdSTsg@mail.gmail.com>
References: <CAHjFwoAyYYSD1VpW7f_=OSQ04paWUhzPJA+uT67s_OS124hbjQ@mail.gmail.com>
	<CAJ-Vmo=heE_3LTgANyhnUjKEUAS2GEKFr1w+cxD39Ss5LAp3=Q@mail.gmail.com>
	<CAHjFwoAgPg7YHJLdP=mX7kq-J4R8CnG_-dcJPSuPPZhTT2BBFQ@mail.gmail.com>
	<CAJ-Vmokt3+L4brGM5AcaNV1BhNBrv4C6FedxPaowO68GwDb9fg@mail.gmail.com>
	<CAJ-VmoksXS+q5kcL09mF-zVJ9msUENZdb_j1+Lj_Y5c7AdSTsg@mail.gmail.com>
From: Kang Yin Su <cantona@cantona.net>
Date: Wed, 24 Aug 2011 22:04:35 +0800
X-Google-Sender-Auth: bAd_MBATRmoqhxwWlkjZGcTq_cY
Message-ID: <CAHjFwoBrnUVkGoP4L1Uuq+=NXbyUkEjxmR41zUwSyHUkpzeiFA@mail.gmail.com>
To: Adrian Chadd <adrian@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: freebsd-wireless@freebsd.org
Subject: Re: [Patch] Set timers mode for AR5416 on TDMA support
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussions of 802.11 stack,
	tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Aug 2011 14:04:56 -0000

That works too I tried, I just think explicit the mode is better.

thanks,
Yin

On Wed, Aug 24, 2011 at 9:27 PM, Adrian Chadd <adrian@freebsd.org> wrote:

> Hi,
>
> Please try this patch. I bet bt_flags isn't 0 sometimes and the "right
> bits" aren't set. :)
>
>
> Adrian
>
> Index: if_ath.c
> ===================================================================
> --- if_ath.c    (revision 224813)
> +++ if_ath.c    (working copy)
> @@ -5485,6 +5485,8 @@
>        bt.bt_nextdba = (nexttbtt<<3) - sc->sc_tdmadbaprep;
>        bt.bt_nextswba = (nexttbtt<<3) - sc->sc_tdmaswbaprep;
>        bt.bt_nextatim = nexttbtt+1;
> +       /* Enables TBTT, DBA, SWBA timers by default */
> +       bt.bt_flags = 0;
>        ath_hal_beaconsettimers(ah, &bt);
>  }
>