Date: Mon, 8 Jun 1998 20:29:49 +0100 (BST) From: Andrew Gordon <arg@arg1.demon.co.uk> To: freebsd-isdn@FreeBSD.ORG, hm@kts.org Subject: Bug in isdnd with multiple dial-out numbers Message-ID: <Pine.BSF.3.96.980608202140.17105A-200000@server.arg.sj.co.uk>
next in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-1221630659-897334189=:17105 Content-Type: TEXT/PLAIN; charset=US-ASCII There is a bug (consistent off-by-one error) in the logic that selects the next telephone number to dial from entries with more than one remote-phone-dialout configured. Effect of the bug was that it would attempt to access entry n+1 in the table, and so attempt to dial a zero-length number (the BT exchange responds with cause 0x1c "Invalid number format", which seems fair enough in the circumstances!). This would happen every third call if you have remdial-handling = next and two numbers configured, less often in other configurations. Patch (for isdnd/dial.c, from 0.61 release) attached. --0-1221630659-897334189=:17105 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="dial.c.patch1" Content-Transfer-Encoding: BASE64 Content-ID: <Pine.BSF.3.96.980608202949.17105B@server.arg.sj.co.uk> Content-Description: KioqIGRpYWwuYy5vcmlnCU1vbiBKdW4gIDggMTk6Mzk6MjEgMTk5OA0KLS0t IGRpYWwuYwlNb24gSnVuICA4IDE5OjQ5OjI3IDE5OTgNCioqKioqKioqKioq KioqKg0KKioqIDg5LDk3ICoqKioNCiAgCQkJfQ0KICAJCQllbHNlDQogIAkJ CXsNCiEgCQkJCWlmKGNlcC0+cmVtb3RlX251bWJlcnNfY291bnQgPiBpKQ0K ISAJCQkJCWkrKzsNCiEgCQkJCWVsc2UNCiAgCQkJCQlpID0gMDsNCiAgDQog IAkJCQlzdHJjcHkoY2VwLT5yZW1vdGVfcGhvbmVfZGlhbG91dCwgY2VwLT5y ZW1vdGVfbnVtYmVyc1tpXS5udW1iZXIpOw0KLS0tIDg5LDk1IC0tLS0NCiAg CQkJfQ0KICAJCQllbHNlDQogIAkJCXsNCiEgCQkJCWlmKCsraSA+PSBjZXAt PnJlbW90ZV9udW1iZXJzX2NvdW50KQ0KICAJCQkJCWkgPSAwOw0KICANCiAg CQkJCXN0cmNweShjZXAtPnJlbW90ZV9waG9uZV9kaWFsb3V0LCBjZXAtPnJl bW90ZV9udW1iZXJzW2ldLm51bWJlcik7DQoqKioqKioqKioqKioqKioNCioq KiAxMDEsMTA5ICoqKioNCiAgCQkJfQ0KICAJCX0NCiAgDQohIAkJaWYoY2Vw LT5yZW1vdGVfbnVtYmVyc19jb3VudCA+IGkpDQohIAkJCWkrKzsNCiEgCQll bHNlDQogIAkJCWkgPSAwOw0KICAJfQ0KICAJc3RyY3B5KGNlcC0+cmVtb3Rl X3Bob25lX2RpYWxvdXQsIGNlcC0+cmVtb3RlX251bWJlcnNbMF0ubnVtYmVy KTsNCi0tLSA5OSwxMDUgLS0tLQ0KICAJCQl9DQogIAkJfQ0KICANCiEgCQlp ZigrK2kgPj0gY2VwLT5yZW1vdGVfbnVtYmVyc19jb3VudCkNCiAgCQkJaSA9 IDA7DQogIAl9DQogIAlzdHJjcHkoY2VwLT5yZW1vdGVfcGhvbmVfZGlhbG91 dCwgY2VwLT5yZW1vdGVfbnVtYmVyc1swXS5udW1iZXIpOw0KKioqKioqKioq KioqKioqDQoqKiogMTM5LDE0NSAqKioqDQogIAkNCiAgCWNlcC0+bGFzdF9y ZW1vdGVfbnVtYmVyKys7DQogIA0KISAJaWYoY2VwLT5sYXN0X3JlbW90ZV9u dW1iZXIgPiBjZXAtPnJlbW90ZV9udW1iZXJzX2NvdW50KQ0KICAJCWNlcC0+ bGFzdF9yZW1vdGVfbnVtYmVyID0gMDsNCiAgDQogIAlzdHJjcHkoY2VwLT5y ZW1vdGVfcGhvbmVfZGlhbG91dCwgY2VwLT5yZW1vdGVfbnVtYmVyc1tjZXAt Pmxhc3RfcmVtb3RlX251bWJlcl0ubnVtYmVyKTsNCi0tLSAxMzUsMTQxIC0t LS0NCiAgCQ0KICAJY2VwLT5sYXN0X3JlbW90ZV9udW1iZXIrKzsNCiAgDQoh IAlpZihjZXAtPmxhc3RfcmVtb3RlX251bWJlciA+PSBjZXAtPnJlbW90ZV9u dW1iZXJzX2NvdW50KQ0KICAJCWNlcC0+bGFzdF9yZW1vdGVfbnVtYmVyID0g MDsNCiAgDQogIAlzdHJjcHkoY2VwLT5yZW1vdGVfcGhvbmVfZGlhbG91dCwg Y2VwLT5yZW1vdGVfbnVtYmVyc1tjZXAtPmxhc3RfcmVtb3RlX251bWJlcl0u bnVtYmVyKTsNCg== --0-1221630659-897334189=:17105-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isdn" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.96.980608202140.17105A-200000>