From owner-freebsd-ports-bugs@FreeBSD.ORG  Sat Apr  5 19:10:03 2008
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6A2AF106564A
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sat,  5 Apr 2008 19:10:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 28B2B8FC1A
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sat,  5 Apr 2008 19:10:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m35JA2vN011068
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Sat, 5 Apr 2008 19:10:02 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m35JA2jE011066;
	Sat, 5 Apr 2008 19:10:02 GMT (envelope-from gnats)
Date: Sat, 5 Apr 2008 19:10:02 GMT
Message-Id: <200804051910.m35JA2jE011066@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
Cc: 
Subject: Re: ports/122469: [patch] options for viewvc
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Apr 2008 19:10:03 -0000

The following reply was made to PR ports/122469; it has been noted by GNATS.

From: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
To: olli hauer <ohauer@gmx.de>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: ports/122469: [patch] options for viewvc
Date: Sat, 5 Apr 2008 15:03:04 -0400

 olli hauer wrote:
 > --- Makefile.orig       2008-04-03 04:39:36.000000000 +0200
 > +++ Makefile    2008-04-04 09:41:51.000000000 +0200
 > @@ -13,13 +13,22 @@
 >  MAINTAINER=    pgollucci@p6m7g8.com
 >  COMMENT=       Web-based Version Control Repository Browsing
 > 
 > -RUN_DEPENDS=   ${PYTHON_LIBDIR}/site-packages/svn/__init__.py:${PORTSDIR}/devel/subversion-python \
 > -               ${PYTHON_LIBDIR}/site-packages/_mysql.so:${PORTSDIR}/databases/py-MySQLdb
 > +OPTIONS=       MYSQL "enable experimental MYSQL support" off \
 > +               MODPYTHON3 "enable mod_python3 support" off
 > +
 > +#.include <bsd.port.pre.mk>
 > +
 > +RUN_DEPENDS=   ${PYTHON_LIBDIR}/site-packages/svn/__init__.py:${PORTSDIR}/devel/subversion-python
 > 
 >  USE_PYTHON=    yes
 >  .if defined (WITH_APACHE)
 >  USE_APACHE=    2.0+
 >  .endif
 > +
 > +.if defined(WITH_MYSQL)
 > +RUN_DEPENDS+=  ${PYTHON_LIBDIR}/site-packages/_mysql.so:${PORTSDIR}/databases/py-MySQLdb
 > +.endif
 > +
 >  .if defined(WITH_MODPYTHON3)
 >  RUN_DEPENDS+=  ${APACHEMODDIR}/mod_python.so:${PORTSDIR}/www/mod_python3
 >  .endif
 1) Needs a PORTVERSION bump, the default depends changed.
 2) Also, the final include needs to change to bsd.port.post.mk
 	from bsd.port.mk
 3) Why not move APACHE into the OPTIONS ?
 4) It might be good to use WITH_APACHE2 not WITH_APACHE in this case
     tough this one is my fault :)
 
 Patch looks good otherwise though.
 
 Please submit and updated PATCH.
 
 Thanks.
 
 -- 
 ------------------------------------------------------------------------
 Philip M. Gollucci (pgollucci@p6m7g8.com)
 c:703.336.9354
 Consultant / http://p6m7g8.net/Resume/resume.txt
 http://riderway.com / http://ridecharge.com
 1024D/EC88A0BF 0DE5 C55C 6BF3 B235 2DAB  B89E 1324 9B4F EC88 A0BF
 
 Work like you don't need the money,
 love like you'll never get hurt,
 and dance like nobody's watching.