From owner-svn-ports-all@FreeBSD.ORG Fri Nov 15 07:44:21 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7889F8E4; Fri, 15 Nov 2013 07:44:21 +0000 (UTC) Received: from mail-we0-x231.google.com (mail-we0-x231.google.com [IPv6:2a00:1450:400c:c03::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9961B2470; Fri, 15 Nov 2013 07:44:20 +0000 (UTC) Received: by mail-we0-f177.google.com with SMTP id t60so3166994wes.36 for ; Thu, 14 Nov 2013 23:44:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=rvcDaxK8QFi5MrXJ8dpIHoPy7ufvgLXTBYrnUOVCWuI=; b=sHuBdwDJjYJswqWZ4/oe1XusMtLLHejhNY/knQN32OLvUjQI7Ha50eCXd9eGr7I/5v bWEK8aV0rDkpGIGCjDlB+BuXjvWXpV5Lsxfx0NG08+pDxLddobTkjCFBqPyqvHJrjFBB cbwaiq29YztylkEDwt36P3h1ycXZe5sqydJ9+BWbyvvNhisPoyfRlrObDzyVVOcpvoRq 6dE4B0BhPKoTpNxNy2ekCyxNdB86uVdpWmHvaxpD1v2TYEVVH/JT/PK5ziUEbhxurvft t8OclIiBVHEjv4RPoMS3t+Fxn0gNQ/F0jS/CixByWqIQnMF0jpXz+EYoYWzM2IR6tIiP ZQHw== X-Received: by 10.180.189.49 with SMTP id gf17mr6175301wic.23.1384501458456; Thu, 14 Nov 2013 23:44:18 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id s20sm2119696wib.1.2013.11.14.23.44.16 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 14 Nov 2013 23:44:17 -0800 (PST) Sender: Baptiste Daroussin Date: Fri, 15 Nov 2013 08:44:15 +0100 From: Baptiste Daroussin To: Adam Weinberger Subject: Re: svn commit: r333807 - head/textproc/multimarkdown Message-ID: <20131115074415.GO56153@ithaqua.etoilebsd.net> References: <201311142331.rAENVAQK039370@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Vy1A5eXR7jld12ZH" Content-Disposition: inline In-Reply-To: <201311142331.rAENVAQK039370@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Nov 2013 07:44:21 -0000 --Vy1A5eXR7jld12ZH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 14, 2013 at 11:31:10PM +0000, Adam Weinberger wrote: > Author: adamw > Date: Thu Nov 14 23:31:09 2013 > New Revision: 333807 > URL: http://svnweb.freebsd.org/changeset/ports/333807 >=20 > Log: > Add an include-able file to facilitate checking out sources from git. > Useful especially for projects that don't have distfiles, or that use > submodules that don't have distfiles. >=20 Hi, This port is full of issues with the ports tree and breaks lot of principle= of the ports tree. 1/ it depends on the https interface of github, meaning you need git compil= ed with the CURL option, which not every body activates 2/ it has no distinfo to validate the distfiles so we have to garanty 2 peo= ple building multimarkdown are building the same thing! if upstream does 2 new commits then git tag -d and git tag th= en you are doomed without noticing. 3/ all distfiles should be individually fetchable and storable. We need to be able to have offline builders, and for them we need to be abl= e to feed them with distfiles by putting them into the distfiles directory of the offline builder, this method totally kills that. 4/ it is using submodules meaning the revision of the bundle code is not kn= own meaning that any single packages can potentially be bundling different code untested by the maintainer. Somone should teach upstream how to make a release or we should not provide packages for them. The right way to handle this imho would be to properly use USE_GITHUB by fetching the distfiles related to the commit/tag multimarkdown depends on Then fetch the same way the distfiles of the submodules. in post-extract move the content of the submodules into the final directory. That should build. I know you ask for advice on this, sorry I haven't find time to help earlie= r. regards, Bapt --Vy1A5eXR7jld12ZH Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlKF0M4ACgkQ8kTtMUmk6EyEQQCeIzjrSwWcGPnEIR/uliKQh54Q wWUAniibFphjbedQ9nsN7A6llb7+tuNM =Mmpc -----END PGP SIGNATURE----- --Vy1A5eXR7jld12ZH--