From nobody Fri Aug 26 05:57:37 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MDTdF1zWNz4ZHKN for ; Fri, 26 Aug 2022 05:57:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MDTdD70y2z3XhT for ; Fri, 26 Aug 2022 05:57:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MDTdD5zb1zHBy for ; Fri, 26 Aug 2022 05:57:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 27Q5vaGs062477 for ; Fri, 26 Aug 2022 05:57:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 27Q5valB062476 for bugs@FreeBSD.org; Fri, 26 Aug 2022 05:57:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 265974] SMR has several missing barriers Date: Fri, 26 Aug 2022 05:57:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661493457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qbfGQ2tJzjqaOnaKpshYjt+51g8G8e1oL2oUyWzyTJ4=; b=viuH6kWb17xA3JJB4SI36JrSYZKL/CAg8JbHePY7yPibFcSLPUPipyBd1NoaJ1YzRkdtXX KeyoL108RSh2sO6W+ZYoINUhyhJDbl6P7vKCgiD7PjQD+bL+DrFagMK+4GYFXhDghMgnVS T7mE7QS3ZeHtfgblLl7O59b3+sd4aZvxAVXAxy3CWpd9vZqDqQfMlsRAEVylcAFiQHHPN7 gI80qHcE0jVk9Zr3Rcc/ARwbp7BWTZKQTSgfxeXIjO32I2/PEwbhzlGNGbqo7FQbQpGveR 7aLlETcFIvwKMJXw6yAyLUbKbP6tn7aw3cTwpG5yRJunopncpYAPYFl/hQc/rg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1661493457; a=rsa-sha256; cv=none; b=mrrVdlIH9GhwUbyygQZ31fkQzTmR2DOwhTfAQ6djQL4jt6vg+U/hUvYtLhej78FtUNTcIT U3c/GU3SVk3CpuK9zubHgnoXl4kbGPSoipDD+WVV5MRVnQJgrZevlm5rbnDOqPBPydrWu8 8Czcan8BSMIDSFSBdb/1+gtQz00vNQih8WJoKuRlnKiKdcAHMLASzB+Yg4grlpTyG1Nbt/ UWgKbcDkt3tE/HIlVU/FOiNJfPZQ+/AZb6fbicByNuz/Ibc4K5adJArB3FffRSzzykE9qp RpWNgP156UcjRhCcDF8GkIxyg4Wqjr86LvHTneHL25fL20ZnrJ44PRLE9/zxng== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265974 --- Comment #3 from Konstantin Belousov --- I believe you are right, but I would wait for an opinion of people who spent a time with smr code. That said, atomic_add_acq on x86 has the sequentially consistent semantic already (which is why you said that it works on Intel, right?). So the #ifdef from the patch in smr_enter() is not needed, use seq_cst fence for all arches. --=20 You are receiving this mail because: You are the assignee for the bug.=