From owner-svn-src-all@FreeBSD.ORG Sun Oct 6 12:23:58 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id DA1609C0; Sun, 6 Oct 2013 12:23:58 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pa0-x22d.google.com (mail-pa0-x22d.google.com [IPv6:2607:f8b0:400e:c03::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9FC512797; Sun, 6 Oct 2013 12:23:58 +0000 (UTC) Received: by mail-pa0-f45.google.com with SMTP id rd3so6119904pab.4 for ; Sun, 06 Oct 2013 05:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:reply-to:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=aYp2SDMPjlfRNSdsL0kRZg3USlXSy6kTYv35uT6HEH0=; b=dTHz0rj/M2QHWQbKJjJrnWMO7Ofh69ecBgtmndy8Y+PFna3Ig92SV4AF2gASXpCaSm +n85lIg2nbcO4jmmM28TxUzSdHQ1iTsb1QEvecgv7RA69zlubLqe0HcautrkPjo2Gcly 8DG80ByJTpOfU7leY1BBGUDHvwvAls7J6EbWQp+/psbdAbiOUR9Cw4NnYpBZxokoJJff gPGKTW3iWFEoTbqbyhPMmb3HTHJ4zH5PrAeZRX4PhrNMJRa/BvK5DYWNwtmo7ychbvs3 uQcVn4iKwTU51Vr9TCuN1ynMFnNLKpszqACRNeqBy74RKpGU1xBz+quc1AlR7jdtuUDd fZGA== X-Received: by 10.66.121.201 with SMTP id lm9mr26195886pab.80.1381062238171; Sun, 06 Oct 2013 05:23:58 -0700 (PDT) Received: from [192.168.1.7] (ppp59-167-128-11.static.internode.on.net. [59.167.128.11]) by mx.google.com with ESMTPSA id ab4sm26681528pbc.43.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 06 Oct 2013 05:23:57 -0700 (PDT) Message-ID: <52515651.6050809@FreeBSD.org> Date: Sun, 06 Oct 2013 23:23:45 +1100 From: Kubilay Kocak User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Bryan Venteicher , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r256066 - head/sys/dev/virtio/network References: <201310051807.r95I7P0M048589@svn.freebsd.org> In-Reply-To: <201310051807.r95I7P0M048589@svn.freebsd.org> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: koobs@FreeBSD.org List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Oct 2013 12:23:58 -0000 On 6/10/2013 5:07 AM, Bryan Venteicher wrote: > Author: bryanv > Date: Sat Oct 5 18:07:24 2013 > New Revision: 256066 > URL: http://svnweb.freebsd.org/changeset/base/256066 > > Log: > Do not hold the vtnet Rx queue lock when calling up into the stack > > This matches other similar drivers and avoids various LOR warnings. > > Approved by: re (marius) > > Modified: > head/sys/dev/virtio/network/if_vtnet.c > > Modified: head/sys/dev/virtio/network/if_vtnet.c > ============================================================================== > --- head/sys/dev/virtio/network/if_vtnet.c Sat Oct 5 16:22:33 2013 (r256065) > +++ head/sys/dev/virtio/network/if_vtnet.c Sat Oct 5 18:07:24 2013 (r256066) > @@ -1700,9 +1700,9 @@ vtnet_rxq_input(struct vtnet_rxq *rxq, s > rxq->vtnrx_stats.vrxs_ipackets++; > rxq->vtnrx_stats.vrxs_ibytes += m->m_pkthdr.len; > > - /* VTNET_RXQ_UNLOCK(rxq); */ > + VTNET_RXQ_UNLOCK(rxq); > (*ifp->if_input)(ifp, m); > - /* VTNET_RXQ_LOCK(rxq); */ > + VTNET_RXQ_LOCK(rxq); > } > > static int > @@ -1782,6 +1782,10 @@ vtnet_rxq_eof(struct vtnet_rxq *rxq) > m_adj(m, adjsz); > > vtnet_rxq_input(rxq, m, hdr); > + > + /* Must recheck after dropping the Rx lock. */ > + if ((ifp->if_drv_flags & IFF_DRV_RUNNING) == 0) > + break; > } > > if (deq > 0) > _______________________________________________ > svn-src-head@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" > Thanks Bryan, confirming no more LOR apparent after this commit :) Is this a good MFC candidate?