From owner-svn-src-head@FreeBSD.ORG Sun Nov 9 08:48:17 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 8C32A1065688; Sun, 9 Nov 2008 08:48:17 +0000 (UTC) Date: Sun, 9 Nov 2008 08:48:17 +0000 From: Alexey Dokuchaev To: Matteo Riondato Message-ID: <20081109084817.GA23323@FreeBSD.org> References: <200811090734.mA97YBld033553@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200811090734.mA97YBld033553@svn.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184780 - head/usr.sbin/cron/crontab X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Nov 2008 08:48:17 -0000 On Sun, Nov 09, 2008 at 07:34:11AM +0000, Matteo Riondato wrote: > > +void > +static remove_tmp(int sig) > +{ > + if (tmp_path) { > + unlink(tmp_path); > + } > + exit(ERROR_EXIT); > +} This looks weird: `static' should be on same line as `void' as `static void' (so ^remove_tmp would match). It will also always exit with ERROR_EXIT, which does not look right, does it? ./danfe