From owner-freebsd-hackers@FreeBSD.ORG  Wed May 14 15:48:53 2008
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CA62C106566B
	for <freebsd-hackers@freebsd.org>; Wed, 14 May 2008 15:48:53 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from kientzle.com (h-66-166-149-50.snvacaid.covad.net
	[66.166.149.50])
	by mx1.freebsd.org (Postfix) with ESMTP id ACD9D8FC19
	for <freebsd-hackers@freebsd.org>; Wed, 14 May 2008 15:48:53 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from [10.0.0.128] (p54.kientzle.com [66.166.149.54])
	by kientzle.com (8.12.9/8.12.9) with ESMTP id m4EFmrtv012137;
	Wed, 14 May 2008 08:48:53 -0700 (PDT)
	(envelope-from kientzle@freebsd.org)
Message-ID: <482B09E5.5010302@freebsd.org>
Date: Wed, 14 May 2008 08:48:53 -0700
From: Tim Kientzle <kientzle@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060422
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Jeff Anton <antonfb@hesiod.org>
References: <20080514120011.9131F10656C4@hub.freebsd.org>
	<482AFC9A.7050807@hesiod.org>
In-Reply-To: <482AFC9A.7050807@hesiod.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-hackers@freebsd.org
Subject: Re: BDB corrupt - patches
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 May 2008 15:48:53 -0000

Jeff Anton wrote:
> Some years ago I mailed patches out to someone regarding
> Berkeley DB 1.85 btree problems.  The two issues which come
> to mind are...
> 
> 1) The page split position is improperly computed. ...
> 2) The record put code has a "last page put to" member ...
> 
> I'm going to have to dig up these fixes, but presuming
> I do, who should be alerted?  Just file a bug?  Recreation
> is extremely difficult.

Definitely file a PR and include the patches.  If nothing
else, that will help ensure they don't get lost.

When you do file that PR, notify this list.  Given how
heavily the base system uses DB 1.85, I think there will
be a lot of interest in anything that improves the
stability and reliability of that code.

Cheers,

Tim Kientzle